Skip to content

src: guard OpenSSL compression header include#64009

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:src-guard-openssl-comp-include
Jun 20, 2026
Merged

src: guard OpenSSL compression header include#64009
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:src-guard-openssl-comp-include

Conversation

@panva

@panva panva commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Follow up to #62217 which for some reason didn't run test-shared.yml which is now failing on main and PRs.

Refs (main): https://github.com/nodejs/node/actions/runs/27836231188/job/82385093927
Refs (PR): https://github.com/nodejs/node/actions/runs/27838253550/job/82391504086

@panva
src: guard OpenSSL compression header include
a18f3ed 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva requested a review from pimterry June 19, 2026 17:23
@panva panva added the fast-track PRs that do not need to wait for 72 hours to land. label Jun 19, 2026
@nodejs-github-bot

nodejs-github-bot commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jun 19, 2026
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 19, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@pimterry

pimterry commented Jun 19, 2026

Copy link
Copy Markdown
Member

Weird, no idea how that didn't fail before. Thanks for the fix!

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74281/

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2026
This was referenced Jun 20, 2026
Closed
Closed
@trivikr

trivikr commented Jun 20, 2026

Copy link
Copy Markdown
Member

Fixes: nodejs/build#4378

@panva

panva commented Jun 20, 2026

Copy link
Copy Markdown
Member Author

Figured out why test-shared.yml didn't for #62217.

https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#git-diff-comparisons

Diffs are limited to 300 files. If there are files changed that aren't matched in the first 300 files returned by the filter, the workflow will not run. You may need to create more specific filters so that the workflow will run automatically.

Files that would've matched came after the 300 limit

346 deps/openssl/openssl.gyp
347 deps/openssl/openssl.gypi
349 lib/internal/tls/secure-context.js
352 src/crypto/crypto_context.cc
359 test/parallel/test-tls-certificate-compression.js

mcollina
mcollina approved these changes Jun 20, 2026
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2026
@nodejs-github-bot nodejs-github-bot merged commit a40bb49 into nodejs:main Jun 20, 2026
89 of 90 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Landed in a40bb49

@panva panva deleted the src-guard-openssl-comp-include branch June 20, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@pimterry pimterry pimterry approved these changes

@richardlau richardlau richardlau approved these changes

@aduh95 aduh95 aduh95 approved these changes

@trivikr trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 72 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@panva @nodejs-github-bot @pimterry @trivikr @mcollina @jasnell @lpinca @richardlau @aduh95