Tests: memcached response length overflow detection - #99
Draft
VadimZhestikov wants to merge 1 commit into
Draft
Conversation
A length that overflows when the size of the response trailer is added to it is rejected, instead of being sent to the client as a content length. Marked TODO, as the fix is not yet released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression test for nginx/nginx#1637 ("Memcached: fixed integer overflow with
large response lengths").
A fake memcached backend returns a
VALUEline with a length of9223372036854775807, which overflows when the size of the response trailer(
"\r\nEND\r\n") is added to it inngx_http_memcached_filter_init().Without the fix nginx accepts it and sends the bogus length on to the client:
and the trailer is never validated. With the fix the response is rejected as
an invalid length and the request fails with 502.
Marked TODO, as the fix is not yet released.