SSL verify partial chain - #88
Draft
andr-cher-scacap wants to merge 2 commits into
Draft
Conversation
9 tasks
guil-camp-scacap
approved these changes
Jul 22, 2026
smpavlenko
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There was no dedicated regression coverage for the new
ssl_verify_client partial_chainmode.Without targeted tests, it would be easy to regress the intended
behavior in one module while the others continue to pass.
Solution
Add focused regression tests for
ssl_verify_client partial_chainin:The tests build a small CA hierarchy with a self-signed root, an
intermediate signed by that root, and a leaf client certificate signed by
the intermediate. The root is intentionally not trusted by nginx, so the
tests specifically verify that
partial_chainaccepts the leafcertificate when the trusted intermediate is present.
The tests also verify that:
ssl_verify_client onstill rejects the sameleaf certificate when only the intermediate is trusted;
partial_chainisexpected to behave like
on.Testing
Validated with:
TEST_NGINX_BINARY=/path/to/nginx/objs/nginx prove -v \ ssl_verify_client_partial_chain.t \ stream_ssl_verify_client_partial_chain.t \ mail_imap_ssl_partial_chain.tResult: all 28 tests passed.
Closes: N/A
Checklist
Before submitting this PR, please confirm:
relevant changes
Release Notes
Added regression coverage for the new
ssl_verify_client partial_chainmode in HTTP, stream, and mail.