Tests: browser module modern_browser inheritance - #86
Open
VadimZhestikov wants to merge 1 commit into
Open
Conversation
A modern_browser directive defined in the http block must be honoured when it is inherited by a server or location that does not redefine it. The inheritance test is marked TODO until the corresponding change is released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
browser.t(there was no browser test) coveringmodern_browserdefined in thehttpblock and inherited by a server that does not redefine it, plus a locally-defined baseline and an ancient-browser case.The inheritance assertion is marked TODO until the corresponding code change is released.
Code PR: nginx/nginx#1579