Tests: whitespace stripping in HTTP/2 field values. - #80
Open
Aayush7352 wants to merge 1 commit into
Open
Conversation
Added tests checking that leading and trailing SP and HTAB characters in HTTP/2 header field values are stripped per RFC 9113, Section 8.2.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression tests for HTTP/2 field value whitespace stripping (nginx/nginx#1572).
What it covers
Four new subtests in h2_headers.t verify that leading and trailing
SP (0x20) and HTAB (0x09) characters are stripped from HTTP/2 field
values per RFC 9113 Section 8.2.2:
Verified
Without the nginx side fix all 4 subtests fail (values arrive with
whitespace intact). With the fix all 116 subtests pass.
Related: nginx/nginx#1572, nginx/nginx#598