Tests: If-Unmodified-Since in DAV methods. - #79
Open
Aayush7352 wants to merge 1 commit into
Open
Conversation
Test that PUT, DELETE, and COPY respect the If-Unmodified-Since precondition, returning 412 Precondition Failed when the file modification time is later than the header date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression tests for the If-Unmodified-Since precondition check in
the DAV module (nginx/nginx#1571).
What the test covers
Precondition Failed, file content unchanged
No Content, file updated
file preserved on disk
→ 412, destination unchanged
are treated as if the header was absent, per RFC 7232, Section 3.4)
Verified
All 105 subtests pass with the fix applied. Without the fix the
6 If-Unmodified-Since tests fail (the DAV module performs the
operation with 204 instead of rejecting with 412).
Related: nginx/nginx#561