Skip to content

Tests: client_body_early_read directive. - #103

Merged
route443 merged 1 commit into
nginx:masterfrom
jimf5:dev/client-body-preread
Sep 2, 2026
Merged

Tests: client_body_early_read directive.#103
route443 merged 1 commit into
nginx:masterfrom
jimf5:dev/client-body-preread

Conversation

@jimf5

@jimf5 jimf5 commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

Added tests for the client_body_early_read directive introduced in PR: nginx/nginx#1641

Checklist

Before creating a PR, run through this checklist and mark each as complete:

@jimf5
jimf5 requested review from arut, pluknet and route443 August 15, 2026 07:02
@jimf5 jimf5 self-assigned this Aug 15, 2026
@jimf5 jimf5 added the tests label Aug 15, 2026
@jimf5
jimf5 force-pushed the dev/client-body-preread branch from 062294f to b6bb50b Compare August 15, 2026 07:55
@sindhushiv sindhushiv moved this from New to In Review in NGINX OSS Unified Workspace Aug 17, 2026
@jimf5
jimf5 force-pushed the dev/client-body-preread branch from b6bb50b to 4d25224 Compare August 17, 2026 18:56
Comment thread client_body_early_read.t Outdated

@pluknet pluknet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with comments

@jimf5
jimf5 force-pushed the dev/client-body-preread branch 2 times, most recently from 4daf606 to 18f9433 Compare August 20, 2026 08:45
@jimf5
jimf5 force-pushed the dev/client-body-preread branch from 18f9433 to 33c136d Compare August 27, 2026 19:48
Comment thread client_body_early_read.t Outdated
Comment thread client_body_early_read.t
Comment thread client_body_early_read.t Outdated
Comment thread client_body_early_read.t
Comment thread client_body_early_read.t Outdated
Comment thread client_body_early_read.t Outdated
Comment thread client_body_early_read.t
@github-project-automation github-project-automation Bot moved this from In Review to In Progress in NGINX OSS Unified Workspace Aug 27, 2026
Comment thread client_body_early_read.t Outdated
Comment thread client_body_early_read.t
Comment thread client_body_early_read.t Outdated
Comment thread client_body_early_read.t Outdated
Comment thread client_body_early_read.t
Comment thread client_body_early_read.t Outdated
@jimf5
jimf5 force-pushed the dev/client-body-preread branch from f250d85 to b6c8564 Compare August 30, 2026 19:41

@jimf5 jimf5 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@route443 Thanks for the review

Comment thread client_body_early_read.t Outdated
Comment thread client_body_early_read.t
Comment thread client_body_early_read.t
Comment thread client_body_early_read.t Outdated
Comment thread client_body_early_read.t
Comment thread client_body_early_read.t Outdated
Comment thread client_body_early_read.t Outdated
Comment thread client_body_early_read.t Outdated
Comment thread client_body_early_read.t Outdated
Comment thread client_body_early_read.t

@route443 route443 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The coverage is 91.67%

@github-project-automation github-project-automation Bot moved this from In Progress to In Review in NGINX OSS Unified Workspace Sep 2, 2026
@route443
route443 merged commit ed41edf into nginx:master Sep 2, 2026
@github-project-automation github-project-automation Bot moved this from In Review to Done in NGINX OSS Unified Workspace Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants