Tests: predicate locations. - #102
Open
jimf5 wants to merge 1 commit into
Open
Conversation
pluknet
reviewed
Aug 18, 2026
Comment on lines
+146
to
+148
| like(http_get('/some/path/?pred2=1'), qr!proxied:/some/path/!, | ||
| 'proxy_pass in predicate'); | ||
| like(http_get('/t?pred3=1'), qr/predfile/, 'root in predicate location'); |
Contributor
There was a problem hiding this comment.
since the tests are about choosing location configuration, these two looks irrelevant
jimf5
force-pushed
the
dev/predicate-locations
branch
2 times, most recently
from
August 19, 2026 09:32
0d045f6 to
ffbdd6b
Compare
pluknet
approved these changes
Aug 19, 2026
jimf5
force-pushed
the
dev/predicate-locations
branch
2 times, most recently
from
August 19, 2026 20:42
3effe16 to
131582d
Compare
Co-authored-by: Sergey Kandaurov <pluknet@nginx.com>
jimf5
force-pushed
the
dev/predicate-locations
branch
from
August 20, 2026 08:44
131582d to
29da160
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added tests for predicate locations introduced in this PR: nginx/nginx#1633
Checklist
Before creating a PR, run through this checklist and mark each as complete:
README.mdand/orCHANGELOG.md).