Skip to content

Remove vendored nf-core utils subworkflows, use plugin imports - #241

Open
maxulysse wants to merge 16 commits into
devfrom
remove-nfcore-utils-subworkflows
Open

Remove vendored nf-core utils subworkflows, use plugin imports#241
maxulysse wants to merge 16 commits into
devfrom
remove-nfcore-utils-subworkflows

Conversation

@maxulysse

Copy link
Copy Markdown
Member

Replace three subworkflows/nf-core/utils_* subworkflows with direct imports from plugin/nf-core-utils and plugin/nf-schema, matching the pattern used by rnavar and createpanelrefs pipelines.

Removed:

  • subworkflows/nf-core/utils_nextflow_pipeline/ — version display, params dump, conda check
  • subworkflows/nf-core/utils_nfcore_pipeline/ — config validation, email, versions YAML
  • subworkflows/nf-core/utils_nfschema_plugin/ — parameter validation, help display

Changes:

  • subworkflows/local/utils_nfcore_seqinspector_pipeline/main.nf — imports now come from plugins, all function calls inlined
  • workflows/seqinspector.nfparamsSummaryMultiqc import changed to plugin
  • modules.json — removed references to deleted subworkflows

All functionality preserved. No loss of features.

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit 5eb9074

+| ✅ 201 tests passed       |+
#| ❔   7 tests were ignored |#
Details

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 4.0.2
  • Run at 2026-06-18 09:00:42

Replace three subworkflows/nf-core/utils_* subworkflows with direct imports
from plugin/nf-core-utils and plugin/nf-schema, matching the pattern used
by rnavar and createpanelrefs pipelines.

- utils_nextflow_pipeline: version display, params dump, conda check
- utils_nfcore_pipeline: config validation, email, versions YAML
- utils_nfschema_plugin: parameter validation, help display

All functionality preserved in the local utils subworkflow using plugin
functions directly.
@maxulysse
maxulysse force-pushed the remove-nfcore-utils-subworkflows branch from 475e16c to 74fb6af Compare June 17, 2026 07:31
@maxulysse
maxulysse changed the base branch from master to dev June 17, 2026 07:31
@nf-core nf-core deleted a comment from github-actions Bot Jun 17, 2026
@maxulysse
maxulysse force-pushed the remove-nfcore-utils-subworkflows branch from 72dff97 to 39e1c25 Compare June 17, 2026 07:49
Move author/year/title/journal fields into a nested publication object
in meta.yml tool entries to align with the new meta-schema.json structure.

New meta.yml structure:
  tools:
    - samtools:
        doi: "10.1093/bioinformatics/btp352"
        publication:
          author: "Li Heng, et al."
          year: 2009
          title: "The Sequence Alignment/Map format and SAMtools"
          source: "Bioinformatics"

Changes:
- Moved author, year, title, journal into publication object
- Renamed journal to source (covers journals, conferences, workshops)
- Renamed authors (plural) to author (singular) for consistency
- Updated 16 meta.yml files across nf-core modules
@maxulysse maxulysse added this to the 1.2.0 milestone Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant