Deprecate quartonotebook module in favour of quarto/notebook - #12659
Merged
Conversation
fasterius
force-pushed
the
quarto/notebook
branch
from
August 12, 2026 13:38
4927f2b to
4cbf068
Compare
fasterius
marked this pull request as ready for review
August 18, 2026 13:50
mahesh-panchal
left a comment
mahesh-panchal
left a comment
Member
There was a problem hiding this comment.
One small thing to fix
| // (which is the default), in order to correctly output `versions.csv`. | ||
| // The other test notebooks are executed by default, so this argument | ||
| // changes nothing there. | ||
| ext.args = "--execute" |
Member
There was a problem hiding this comment.
Args can be supplied in a parameter block on a test specific basis like so
https://nf-co.re/docs/specifications/components/modules/testing#configuration-of-extargs-in-tests. Please use this.
Contributor
Author
There was a problem hiding this comment.
I hadn't seen that before, thanks!
mahesh-panchal
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates the
quartonotebookmodule in favour ofquarto/notebook, since another Quarto-related module has been added (quarto/prerender: #12187).PR checklist
nf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda