Repository navigation
Release 1.2.0 #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release 1.2.0 #228
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
ee6503e
Update nf-schema and ignore igenomes in config (#210)
erikrikarddaniel e9fd85f
Add species-preference ability (#212)
erikrikarddaniel c724363
Template update for nf-core/tools 4.0.3, and update nf-core modules a…
erikrikarddaniel d6618ac
Remove vulnerable PR-comment artifact pattern (#216)
mashehu dbffd1e
Add Bakta as an alternative to Prokka for genome annotation (#217)
erikrikarddaniel 18cc48c
Add --save_parquet to also write summary tables as Parquet (#219)
erikrikarddaniel e50c954
Document read-count units and fix brittle R code in COLLECT_STATS/COL…
erikrikarddaniel 737f8b4
Template sync to nf-core/tools 4.1.0 and module updates (#223)
erikrikarddaniel 9761653
Bump version: 1.2.0dev -> 1.2.0 (#224)
erikrikarddaniel 3b21bc0
Remove vulnerable PR-comment artifact pattern (#226)
erikrikarddaniel 338513d
Remove vulnerable PR-comment artifact pattern (#227)
erikrikarddaniel 223d8df
Merge remote-tracking branch 'upstream/master' into dev
erikrikarddaniel d80e66b
Document potential Prokka/Bakta version drift across a reused store d…
erikrikarddaniel ae6f0c0
Update CHANGELOG with recent fixes and documentation
erikrikarddaniel ceb333b
Address review comments: DuckDB citation, Bakta dirs, docs gaps
erikrikarddaniel 4d8686e
Fix COLLECT_GENOMESELECTION not scaling to large genome collections
erikrikarddaniel d26ca97
Address remaining review comments from vagkaratzas
erikrikarddaniel 5173522
Rename remaining local modules' leftover r-test environment.yml name
erikrikarddaniel ba3b33f
Address remaining vagkaratzas review items
erikrikarddaniel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| #!/usr/bin/env bash | ||
|
vagkaratzas marked this conversation as resolved.
Resolved
|
||
| # This hook is used to block commits if they include staged files inside a directory | ||
| # which also contains a subdirectory called `pipeline_info`. The purpose of this is to | ||
| # prevent users from inadvertently committing output from pipeline test runs inside the | ||
| # development directory. | ||
|
|
||
| set -e | ||
|
|
||
| status=0 | ||
| seen_dirs="" | ||
|
|
||
| while IFS= read -r file; do | ||
| # The offending output bundle's root is the ancestor directory that has | ||
| # `pipeline_info` as an immediate child, so callers can restore it in one go. | ||
| if [[ "$file" == pipeline_info/* ]]; then | ||
| top_dir="pipeline_info" | ||
| elif [[ "$file" == */pipeline_info/* ]]; then | ||
| top_dir="${file%%/pipeline_info/*}" | ||
| else | ||
| top_dir="" | ||
| dir=$(dirname "$file") | ||
| while [[ "$dir" != "." && "$dir" != "/" ]]; do | ||
| if [[ -d "$dir/pipeline_info" ]]; then | ||
| top_dir="$dir" | ||
| break | ||
| fi | ||
| dir=$(dirname "$dir") | ||
| done | ||
| fi | ||
|
|
||
| if [[ -n "$top_dir" ]]; then | ||
| echo "❌ Commit blocked: Please do not commit output from pipeline test runs to the pipeline code itself: $file" | ||
| status=1 | ||
| case "$seen_dirs" in | ||
| *"|$top_dir|"*) ;; | ||
| *) | ||
| echo "Run 'git restore --staged $top_dir' to remove the whole output folder from the staging area." | ||
| seen_dirs="$seen_dirs|$top_dir|" | ||
| ;; | ||
| esac | ||
| fi | ||
| done < <(git diff --cached --name-only) | ||
|
|
||
| exit "$status" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might need to add
magmap_bakta,magmap_bakta_db, andmagmap_bakta_db_testif, as byconf/test_bakta.config:53, are created in the launch directory