Repository navigation
fix: unique custom tokens for share links - #65725
Merged
leftybournes merged 3 commits intoOct 30, 2026
Merged
Conversation
leftybournes
requested review from
Altahrim,
icewind1991,
salmart-dev and
sorbaugh
and removed request for
a team
October 20, 2026 14:48
Member
Author
|
Failing tests are related. Looking into it 👀 Edit: Done |
leftybournes
force-pushed
the
leftybournes/fix/sharing_links_unique_custom_token
branch
from
October 29, 2026 07:02
8bed7df to
f1b0ebd
Compare
Signed-off-by: Kent Delante <kent@delante.me>
leftybournes
force-pushed
the
leftybournes/fix/sharing_links_unique_custom_token
branch
2 times, most recently
from
October 29, 2026 08:16
d9ea886 to
92f0ec1
Compare
cristianscheid
left a comment
cristianscheid
left a comment
Member
There was a problem hiding this comment.
CI errors seem related
susnux
approved these changes
Oct 29, 2026
Signed-off-by: Kent Delante <kent@delante.me>
Signed-off-by: Kent Delante <kent@delante.me>
leftybournes
force-pushed
the
leftybournes/fix/sharing_links_unique_custom_token
branch
from
October 29, 2026 23:11
92f0ec1 to
665e61d
Compare
leftybournes
requested review from
kristian-zendato,
pabzm and
skjnldsv
and removed request for
a team
October 29, 2026 23:11
Member
Author
|
@cristianscheid It was a linter error. It's fixed now. |
cristianscheid
approved these changes
Oct 30, 2026
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
leftybournes
enabled auto-merge
October 30, 2026 12:45
leftybournes
deleted the
leftybournes/fix/sharing_links_unique_custom_token
branch
October 30, 2026 12:55
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It is currently possible to set a public share's token to an already existing token. For example, if a share with the token 'abc123' already exists, another share can be created with the exact same token. But when visiting the share via
/s/abc123, it always resolves to the first share that was created.This fixes it so that it no longer allows a user to set an already used token and shows an error.
Checklist
3. to review, feature component)stable32)AI (if applicable)