Reload on token-expired app error - #3837
Open
Hyatzy wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds client-side handling in the News frontend to auto-reload when a specific “token expired” error is detected, addressing the long-running-tab scenario described in #638.
Changes:
- Add an
App.vuewatcher onapp.errorthat triggers a full page reload when the token-expired error message appears. - Add a unit test to assert the reload behavior is triggered for that error.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/App.vue |
Adds token-expired detection and a reloadPage() helper to reload the app automatically. |
tests/javascript/unit/components/App.spec.ts |
Adds a unit test verifying the watcher triggers a reload on the token-expired error. |
Comment on lines
+94
to
+96
| reloadPage() { | ||
| window.location.reload() | ||
| }, |
Comment on lines
+62
to
+69
| it('should reload when token error is shown', () => { | ||
| const reloadSpy = vi.spyOn(wrapper.vm, 'reloadPage').mockImplementation(() => {}) | ||
| const error = new Error('Token expired or app not enabled! Reload the page!') | ||
|
|
||
| wrapper.vm.$options.watch['app.error'].handler.call(wrapper.vm, error) | ||
|
|
||
| expect(reloadSpy).toHaveBeenCalled() | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a small App.vue watcher that reloads the page when the news app reports the "Token expired or app not enabled! Reload the page!" error, plus a unit test.
Refs #638.