Fix multi-node recurrent import (e.g. NIR paper SRNN network)#48
Merged
Conversation
…e inputs module_name is santized on line 381, but the call to _find_recursive_inputs used the original edge names from the graph
Jegp
approved these changes
Sep 21, 2025
Jegp
left a comment
Jegp
left a comment
Collaborator
There was a problem hiding this comment.
Looks good so far. If the tests are passing, we should assume it's functional. If not, we should add the unit test! :-)
Would you like to do the honor of merging @fabio-innatera ?
Collaborator
Author
|
Thanks for the review! The fix works with NIRTorch, Norse, snnTorch and Talamo, so I am optimistic that it's correct :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for the issue described here: norse/norse#427
I am not 100% convinced that this has no impact on any other network, but NIRTorch and Norse test suite are all passing.
I think we should have a test for this, but I don't have time right now to work on this further.