Migrated type and metadata field to NIRNode dataclass field factory#191
Open
Jegp wants to merge 1 commit into
Open
Migrated type and metadata field to NIRNode dataclass field factory#191Jegp wants to merge 1 commit into
Jegp wants to merge 1 commit into
Conversation
benkroehs
reviewed
Jun 30, 2026
|
|
||
| # Shape of incoming data. Overrides the keyword-only input_type from | ||
| # NIRNode so it can be passed positionally | ||
| input_type: Types |
Collaborator
There was a problem hiding this comment.
this needs to be dropped, no?
benkroehs
reviewed
Jun 30, 2026
benkroehs
left a comment
benkroehs
left a comment
Collaborator
There was a problem hiding this comment.
looks good, just one minor question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses a nifty Python 3.10 dataclass feature to add default dict constructors to the
input_type,output_type, andmetadatafields inNIRNode, which removes a lot of redundant lines in inherited classes