Skip to content

Fix some issues preventing lsp codegen - #1

Closed
kubukoz wants to merge 2 commits into
neandertech:mainfrom
kubukoz:fix-bugz
Closed

kubukoz wants to merge 2 commits into
neandertech:mainfrom
kubukoz:fix-bugz

Conversation

@kubukoz

@kubukoz kubukoz commented Mar 7, 2026

Copy link
Copy Markdown

I'll come back with tests, I promise

def renderInteger = {
val int = number.longValue()
if (int >= 0) s"+$int" else s"-$int"
if (int >= 0) s"+$int" else s"$int"

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

negative ints already contain a minus.

val modifier = member.renderDefault match
case Some(value) => s"(Default $value)"
case None => "Required"
case None => "FieldModifier.Required"

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@kubukoz

kubukoz commented Mar 12, 2026

Copy link
Copy Markdown
Author

superseded by #2

@kubukoz kubukoz closed this Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant