git-stats CHANGELOG: the release is 0.1.2, not 0.1.1 - #26
Merged
Conversation
The entry was written as 0.1.1 and the release came out as 0.1.2, so the file named a version that does not exist while the one on npm had no entry. `bump=patch` computes off the newest `git-stats-v*` tag, which was `git-stats-v0.1.1-beta.1`. release.yml strips the prerelease suffix and bumps the base, so a beta of 0.1.1 consumes the 0.1.1 number and the next patch is 0.1.2. That is defensible — a beta is a promise about a version — but it means the release a beta anticipated has to be cut with an explicit `-f version=`, never `bump=patch`. Recorded as a comment in the file so the gap between 0.1.0 and 0.1.2 does not read as a lost release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entry was written as
0.1.1; the release came out as0.1.2. So the changelognamed a version that does not exist, and the version on npm had no entry.
bump=patchcomputes off the newestgit-stats-v*tag, which wasgit-stats-v0.1.1-beta.1.release.ymlstrips the prerelease suffix and bumps thebase, so a beta of 0.1.1 consumes the 0.1.1 number and the next patch is 0.1.2.
That behaviour is defensible — a beta is a promise about a version — but it has a
consequence worth writing down: the release a beta anticipated cannot be cut with
bump=patch, only with an explicit-f version=. Left as a comment in the file sothe gap between 0.1.0 and 0.1.2 does not read as a lost release.
0.1.2is live,latestpoints at it, and its provenance namesrefs/tags/git-stats-v0.1.2.