git-stats CHANGELOG: record 0.1.1-beta.1 and what it was for - #23
Merged
Conversation
release.yml warned that this version had no CHANGELOG section, correctly. The entry says what the version actually is: nothing in the plugin changed, and `git diff git-stats-v0.1.0 git-stats-v0.1.1-beta.1 -- src dist` is empty. Only the repository.url/homepage metadata moved, following the repo rename. It also records why the version exists, since a reader finding a beta that contains no changes deserves the reason: the release path had never been run for this package, and running it is the only way to learn whether it works. It did not — the npm deployment environment admitted only `v*` tags, the pre-monorepo scheme, so the publish job was rejected before its first step, with no failing step and no log. Fixed by also allowing `*-v*`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release.ymlwarned that0.1.1-beta.1had no CHANGELOG section. It was right,so here it is.
The entry says what the version actually is — nothing in the plugin changed;
git diff git-stats-v0.1.0 git-stats-v0.1.1-beta.1 -- src distis empty, and onlythe
repository.url/homepagemetadata moved with the repo rename.It also records why it exists, because a reader who finds a beta containing no
changes deserves the reason: the release path had never been run for this package,
and running it is the only way to find out whether it works. It didn't — the
npmdeployment environment admitted only
v*tags, the scheme this repo used before itbecame a monorepo, so the publish job was rejected before its first step, with no
failing step and no log to read. Fixed by also allowing
*-v*.The entry states the version is deprecated on npm; holding this PR until that is
actually done, so the changelog is true when it lands.