Revise enum code gen#1011
Open
bocchino wants to merge 13 commits into
Open
Conversation
Kronos3
requested changes
Jun 10, 2026
Kronos3
left a comment
Kronos3
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, some minor nits.
| { | ||
| SerialType es; | ||
| Fw::SerializeStatus status = buffer.deserializeTo(es, mode); | ||
| if ((status == Fw::FW_SERIALIZE_OK) && !isValid(es)) { |
Collaborator
Author
There was a problem hiding this comment.
For an instance member, I would agree. However, isValid is a static member. Are we sure we want to use this-> here? It seems misleading to me, because in fact this has no part in the dispatch of that function.
@LeStarch Do you have an opinion here? I guess the F Prime style guide does say to use this-> for all class members. https://github.com/nasa/fprime/wiki/F´-Style-Guidelines#class-self-references-this-
Collaborator
There was a problem hiding this comment.
Oh right I didnt realize this was a static function. Though that does bring up an interesting point, maybe ClassName::isValid() is best since it's more clear what the function is.
Kronos3
reviewed
Jun 10, 2026
| || ((e >= B) && (e <= B)) | ||
| || ((e >= C) && (e <= C)) | ||
| || ((e >= D) && (e <= D)); | ||
| return isValid(this->e); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR revises the
isValidfunction for enums so the implementation does not rely on undefined behavior in C++. It also incidentally modernizestypedeftousingin the generated code.Closes #1001.
Tandem with this branch: https://github.com/bocchino/fprime/tree/fpp-issue-1001-invalid-enum.