Repository navigation
Repair two snippets and ensure there is a validation script using data for each snippet - #18
Merged
Merged
Conversation
- access_gridded_hdf5.py: use dt[...].ds, and pass phony_dims="access" explicitly - access_trajectory_hdf5.py: list h5py separately in the install line, since h5netcdf made it an optional extra in 1.8.0 - assign `data` in the 6 snippets lacking it, naming the array as read - access_gridded_netcdf4.py: bind `data` to one time step and level, rather than grabbing the full global grid; also pin engine="h5netcdf" and drop the conditional that left `data` undefined - add 6 validate_access_*.py wrappers reusing ducs_validation.validate() - .gitignore: add *.h5, *.hdf5, *.tif, *.tiff
danielfromearth
changed the title
data for each snippet
danielfromearth
requested review from
ebolch,
jschap1 and
rupesh2
and removed request for
rupesh2
October 1, 2026 20:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two defects in #17, and ensures there is a validation script and
datavariable assigned for all current snippets.Note that runtime may take longer because assigning
datawill force an actual data read for each snippet.(I'm thinking a future PR will consolidate the validation scripts into a single script, that is configurable across snippets.)