Skip to content

Fix example highlight styling on the homepage - #1224

Merged
TimMonko merged 1 commit into
napari:mainfrom
TimMonko:fix/custom-css-missing-brace
Nov 16, 2026
Merged

TimMonko merged 1 commit into
napari:mainfrom
TimMonko:fix/custom-css-missing-brace

Conversation

@TimMonko

@TimMonko TimMonko commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Description

Due to a bad merge combo of #1168 and #1169, the homepage featured gallery example layout was broken. This unfortunately means things look this way on 0.10.0 :( This adds back the missing } for the first rule so they are separate again.

Main / 0.10.0:
image

How it looks now again:
image

The closing brace of the .homepage-quicklinks + .community-socials rule was lost when napari#1168 was merged alongside napari#1169. With CSS nesting, every later rule (sidebar link icons, homepage featured example) was nested under that selector and never matched, breaking the featured gallery example layout on the homepage.
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Nov 16, 2026
@TimMonko TimMonko added this to the 0.10.1 milestone Nov 16, 2026
@github-actions

Copy link
Copy Markdown

@Aniketsy Aniketsy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, how it got missed ...LGTM 👍

@TimMonko

Copy link
Copy Markdown
Member Author

ahh, how it got missed ...LGTM 👍

I suppose that's the sneakiness of css, it doesn't fail like a python script would 😆

@TimMonko
TimMonko merged commit d052819 into napari:main Nov 16, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants