Annotate always-true/false condition bugs with //! @bug - #771
Open
quarrel07 wants to merge 1 commit into
Open
Conversation
Comment-only: preprocessed output is byte-identical, so the build still matches. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents six vanilla conditions that always evaluate the same way, using the existing //! @bug convention:
func_802B4104(blue/red shells): both landing checks OR two comparisons that were likely meant to be an && band, so one is always true and the other collapses to a single testactors_extended.c): all three rotation-arc gates are always true, so a shell fires on the first Z press regardless of where it is in the arcrender_player.c): one range has inverted bounds and never matches, so that stretch of lamps never lights the player on Bowser's Castle / Banshee BoardwalkFound while clearing compiler warnings in the SpaghettiKart port (HarbourMasters/SpaghettiKart#691) with (HarbourMasters/SpaghettiKart#725). Comment-only change: the preprocessed output is byte-identical, so matching is unaffected.
🤖 Generated with Claude Code