Skip to content

[Develop ] Set Z region as PAL and fix region link #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Suprapote wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Develop ] Set Z region as PAL and fix region link #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/menu/rom_info.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,9 +711,8 @@ static rom_tv_type_t determine_tv_type (rom_destination_type_t rom_destination_c
// But they are mainly PAL regions.
case MARKET_OTHER_X:
case MARKET_OTHER_Y:
return ROM_TV_TYPE_PAL;
// FIXME: We cannot be sure on these markets, so just return the default for the moment!
case MARKET_OTHER_Z:
return ROM_TV_TYPE_PAL;
default:
return ROM_TV_TYPE_UNKNOWN;
}
Expand Down
9 changes: 4 additions & 5 deletions src/menu/views/load_rom.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,7 @@ static const char *format_rom_media_type (rom_category_type_t media_type) {
}

static const char *format_rom_destination_market (rom_destination_type_t market_type) {
// TODO: These are all assumptions and should be corrected if required.
// From http://n64devkit.square7.ch/info/submission/pal/01-01.html
// From https://ultra64.ca/files/documentation/online-manuals/man-v5-2/allman52/
switch (market_type) {
case MARKET_JAPANESE_MULTI: return "Japanese & English"; // 1080 Snowboarding JPN
case MARKET_BRAZILIAN: return "Brazilian (Portuguese)";
Expand All @@ -192,9 +191,9 @@ static const char *format_rom_destination_market (rom_destination_type_t market_
case MARKET_GATEWAY64_NTSC: return "LodgeNet/Gateway (NTSC)";
case MARKET_GATEWAY64_PAL: return "LodgeNet/Gateway (PAL)";
case MARKET_EUROPEAN_BASIC: return "PAL (includes English)"; // Mostly EU but is used on some Australian ROMs
case MARKET_OTHER_X: return "Regional (non specific)"; // FIXME: AUS HSV Racing ROM's and Asia Top Gear Rally use this so not only EUR
case MARKET_OTHER_Y: return "European (non specific)";
case MARKET_OTHER_Z: return "Regional (unknown)";
case MARKET_OTHER_X: return "PAL (Regional)"; // AUS HSV Racing ROM's and Asia Top Gear Rally but it's PAL specific
case MARKET_OTHER_Y: return "European (Regional)"; //Used on language variations of european ROMs
case MARKET_OTHER_Z: return "PAL (Miscellaneous)"; //Some australian ROMs use this, but also some European ROMs.
default: return "Unknown";
}
}
Expand Down
Loading