Skip to content

feat: add gumlet-video-element- #250 - #257

Open
mudit2108 wants to merge 12 commits into
muxinc:mainfrom
gumlet:main
Open

mudit2108 wants to merge 12 commits into
muxinc:mainfrom
gumlet:main

Conversation

@mudit2108

@mudit2108 mudit2108 commented Sep 8, 2026

Copy link
Copy Markdown

Add an HTMLMediaElement-compatible custom element backed by Gumlet Player.js, with React wrapper, Next.js demo, and release-please registration.


Note

Low Risk
Additive new package following existing embed-element patterns; risk is mainly third-party Player.js/CDN and iframe playback edge cases, covered by targeted tests.

Overview
Introduces gumlet-video-element (<gumlet-video>), a new embed player package that mirrors the repo’s other video custom elements: Gumlet embed URLs (play.gumlet.io/embed/...), an HTMLMediaElement-style API, and Player.js loaded from jsDelivr to drive an iframe in shadow DOM.

Notable behavior in the new implementation includes a config object (DRM, ads, start_high_res, etc.) merged into the embed URL, disable_player_controls when controls is absent (for Media Chrome), SSR hydration via data-config on the iframe and a src refresh so Player.js can handshake, and lifecycle handling for reconnect, invalid src, and loadComplete promises.

Also wires the package into release-please at 0.1.0, documents it in the root README, adds a Next.js demo page/nav entry, and includes TypeScript types, a demo index.html, and zora tests.

Reviewed by Cursor Bugbot for commit 053aa6e. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown

@mudit2108 is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@snyk-io

snyk-io Bot commented Sep 8, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 4 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8d942f8. Configure here.

Comment thread packages/gumlet-video-element/gumlet-video-element.js
Comment thread packages/gumlet-video-element/gumlet-video-element.js
Comment thread packages/gumlet-video-element/gumlet-video-element.js
Comment thread packages/gumlet-video-element/gumlet-video-element.js

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin zora to 6.0.0 version to avoid CORS error on tests run.

{
    "zora": "https://cdn.jsdelivr.net/npm/zora@6.0.0/dist/index.js"
}

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants