Repository navigation
Add TS.QUERYLABELS support to RediStick-TimeSeries - #96
Merged
Merged
Conversation
Create `doc/plans/common-patterns.md` to document the Parameter-Class pattern and update `CLAUDE.md` to reference it for future development.
Adds tsQueryLabels, tsQueryLabelsFilterBy:, tsQueryLabelValues:, and tsQueryLabelValues:filterBy: to RsRedisEndpoint, reusing the existing RsTsFilterBuilder/RsTsFilter machinery for the optional FILTER clause. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
mumez
changed the title
Consolidate command building logic into a private helper method to reduce code duplication across query and label value retrieval methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
RsTsReadCursorandRsTsReadOptions(with BLOCK/MAX_COUNT validation) added forTS.READ.RsRedisEndpoint >> tsRead:cursor:and related methods added forTS.READsupport.RsRedisEndpoint >> tsQueryLabels,tsQueryLabelsFilterBy:,tsQueryLabelValues:,tsQueryLabelValues:filterBy:added forTS.QUERYLABELS, reusing the existingRsTsFilterBuilder/RsTsFilterfilter machinery.RsTsTest(TS.READ coverage additions),RsTsReadOptionsTest,RsTsQueryLabelsTest.doc/plans/common-patterns.mddocuments reusable implementation patterns (e.g. the Parameter-Class Pattern used byRsTsReadCursor), referenced fromCLAUDE.md.doc/plans/2026-09-07-ts-read-implementation.mdanddoc/scripting-features/feature-ts-read.scripting.md/feature-ts-querylabels.scripting.mdrecord the implementation plan and orchestration scripts used.Commits Included
43e2bed Add TS.QUERYLABELS support to RediStick-TimeSeries
d48b749 Add documentation for common implementation patterns