Open
Conversation
FileEX
requested changes
Apr 20, 2026
…Bob/mtasa-blue into fix/player-damage-event-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The onPlayerDamage event was broken, attacker, bodypart and weapon info was no longer being sent.
This seems to have been erroneously removed when resetting the bitstream version and getting rid of version checks.
The version check however was still present on the the VehiclePuresyncPacket (but not the CSim variant). This also would've caused vehicle sync to completely break some ~23 bitstream versions in the future.
This PR:
Motivation
Otherwise stuff would break
Test plan
This simple script could reproduce the issue:
Before these fixes the output would be:
(Even though SAES>NanoBob shot SAES>NanoLaptop)
After the fix it looks like this:
Checklist