-
Notifications
You must be signed in to change notification settings - Fork 13
Fetch growth estimates from Zacks (fix #99) #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kocielnik
wants to merge
19
commits into
mrhappyasthma:master
Choose a base branch
from
kocielnik:test-zacks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
56dcb5e
Fix growth estimate (use Zacks) (#91).
kocielnik 66be6b9
Remove all print() statements.
kocielnik 5766efe
Merge branch 'master' into master
kocielnik 4f1e990
Simplify tests.
kocielnik 50e6a77
WIP: Test Zacks.
kocielnik 3350bf7
Merge branch 'master' into test-zacks
kocielnik 1ca3801
Fix a test.
kocielnik 1ee8abe
Fix growth estimation.
kocielnik 22812e4
Add vercel.json.
kocielnik 63c2126
Merge branch 'test-zacks' into live
kocielnik fb9e2f2
Migrate deployments to UV.
kocielnik 399b475
Use the estimate for next year if 5 years not available.
kocielnik 29837c9
Merge branch 'test-zacks' into live
kocielnik 6d1c926
Fix getting the estimate for next year.
kocielnik 0450644
Make the API path flexible.
kocielnik c8eb251
Remove Vercel config.
kocielnik 61dc175
Revert changes related to migration to UV.
kocielnik 86cf5f1
Revert an unrelated change to module StockRow.
kocielnik ab2f276
Guard against yahoo_finance_analysis being None.
kocielnik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |
|
|
||
| def test_msn_money(): | ||
| test_ticker = 'MSFT' | ||
| test_name = 'Microsoft Corp' | ||
| test_name = 'Microsoft Corporation' | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The data returned from the source changed. |
||
|
|
||
| data = get_msn_money_data(test_ticker) | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| from isthisstockgood.Active.Zacks import Zacks | ||
|
|
||
| def test_zacks(): | ||
| zacks = Zacks("TSLA") |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The opening bracket is important. Earlier on the page, "Next Year" appears in another context, and there it lacks the parentheses.