Migration to erlang-dbus/next - #3
Open
jeanparpaillon wants to merge 27 commits into
Open
Conversation
CI should take care of retro-compatibility, if any Prefer to use latest elixir and erlang versions for developing
With current elixir version, saxy v1.4.x produces lot of compilation warnings
Add top-level ExDBus module
Let's consider this application is the DBus library for elixir
DBus Bus Proxy Message Connection
Router protocol depends on a struct
DBus.Service is the base module for building D-Bus services It integrates Schema and Routing for dispatching events DBus.Bus handle name registration and PubSub suscription for Service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, thank you for the huge work on ex_dbus.
The DSL is really nice !
This is a big PR that builds ex_dbus on top of refreshed erlang-dbus
I rewrote erlang-dbus, trying to make it more robust (more tested), easier to use:
So, I started adapting ex_dbus to this new version of erlang-dbus
Of course, with such rewrite, I introduce a lot of changes, sometimes with my personal opinion.
I'd really appreciate your feedback.
I think I understand most of your choices. When building Service, however, I hardly figure out how the Router protocol, the schema based dispatching and process based objects articulate. I kept the API to register objects on service, but events are not dispatched to them. Do you confirm this is still wip ?