Skip to content

match old devhub urls; add Coming soon for unimplemented views - #25708

Open
eviljeff wants to merge 6 commits into
mozilla:masterfrom
eviljeff:16477-use-devhub-compatible-urls-in-pinguino
Open

eviljeff wants to merge 6 commits into
mozilla:masterfrom
eviljeff:16477-use-devhub-compatible-urls-in-pinguino

Conversation

@eviljeff

@eviljeff eviljeff commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Fixes mozilla/addons#16477

Description

Slightly larger scope than mozilla/addons#16477 - it attempts to address all urls that differ between pinguino and django devhub. The aim was to be able to flip back and forth between pinguino and old devhub without error pages.

Context

  • The generic Coming Soon component serves as a useful proxy for pages we still need to implement
  • as you can see in urls.py, there are a few urls that pingino uses that are inconsistent with django devhub, but they seemed like deliberate design choices, so added django redirects instead.
  • there are some pages/content that we've merged into a single page - e.g. /developers/addons, /developers/themes, and /developers/feed are all on /developers now, so you can't flip twice to get back to the same page. I can think of a solution (e.g. including the old path as a GET param) but it seemed out of scope for this PR (which was already scope ballooned from just /addon/.../edit)
    • Added!
  • in django we have RemoveSlashMiddleware but there's nothing equivalent in pinguino (yet) so if you add a / to the end of a url, it fails. We could fix this in a follow-up by adding a regex to the urls that optionally accepted /, or by reimplementing RemoveSlashMiddleware in django.

Testing

  • With the pinguino flag enabled, toggle in and out of pinguino on various pages
  • All the pages should work without errors, and redirect where necessary
    • missing pages in pinguino should show Coming Soon

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

@eviljeff
eviljeff marked this pull request as ready for review October 29, 2026 15:07
@eviljeff
eviljeff requested a review from a team as a code owner October 29, 2026 15:07
@eviljeff
eviljeff requested review from nothingrandom and removed request for a team October 29, 2026 15:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Pinguino - Should support /{addon}/edit URL, redirecting to /{addon} at least, for compatibility with existing

1 participant