Skip to content

Add Versions List in Pinguino - #25694

Merged
chrstinalin merged 3 commits into
mozilla:masterfrom
chrstinalin:#16505-version-list
Oct 30, 2026
Merged

chrstinalin merged 3 commits into
mozilla:masterfrom
chrstinalin:#16505-version-list

Conversation

@chrstinalin

@chrstinalin chrstinalin commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Fixes mozilla/addons#16505

Description

Adds version list in Pinguino.

image image image

Testing

Navigate to developers/addon/<slug>/versions in Pinguino, after setting VITE_AMO_SESSION_ID. Should be able to:

  1. Navigate to version upload flow
  2. Toggle visibility of listing
  3. See incomplete state, if applicable.

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).

@chrstinalin
chrstinalin marked this pull request as ready for review October 27, 2026 18:02
@chrstinalin
chrstinalin requested a review from a team as a code owner October 27, 2026 18:02
@chrstinalin
chrstinalin requested review from eviljeff and removed request for a team October 27, 2026 18:02

@eviljeff eviljeff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that behaviour with the visibility toggle next to the current version what was designed by UX/Product? I kind of assumed it would do something to the version (e.g. disable it), but it does something to the add-on instead (developer disables it).

Comment thread src/pinguino/devhub/src/data/api.ts Resolved
Comment thread src/pinguino/devhub/src/app.css Resolved
@eviljeff

Copy link
Copy Markdown
Member

btw, /developers/addon/<addon-id>/versions/<version-pk> is just an empty page - I'm assuming it's still to be implemented

@chrstinalin

Copy link
Copy Markdown
Contributor Author

btw, /developers/addon//versions/ is just an empty page - I'm assuming it's still to be implemented

Yeah, I split it off mozilla/addons#16532 since the design's more involved

@chrstinalin

Copy link
Copy Markdown
Contributor Author

Is that behaviour with the visibility toggle next to the current version what was designed by UX/Product? I kind of assumed it would do something to the version (e.g. disable it), but it does something to the add-on instead (developer disables it).

Yeah, you can see it here. For disable, it's on the detail page here

@chrstinalin
chrstinalin requested a review from eviljeff October 29, 2026 19:08

@eviljeff eviljeff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I'm not really convinced that showing the add-on wide visibility (disable) toggle next to a single version makes conceptual sense, but that does seem to be what UX/Product have designed so I'll defer to their expertise.

Just the font question.

@chrstinalin
chrstinalin merged commit 9277e36 into mozilla:master Oct 30, 2026
48 checks passed

@nothingrandom nothingrandom left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Biggest general issue is on dark mode;

Image

? html`<button class="toggle" popovertarget="popover">${badge}</button>`
: badge
}
<div id="popover" class="popover" popover>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Pinguino - Addon Version page

3 participants