Repository navigation
Add Versions List in Pinguino - #25694
Conversation
6293a1b to
5d40f10
Compare
5d40f10 to
f99dce3
Compare
f99dce3 to
f0b1af5
Compare
eviljeff
left a comment
There was a problem hiding this comment.
Is that behaviour with the visibility toggle next to the current version what was designed by UX/Product? I kind of assumed it would do something to the version (e.g. disable it), but it does something to the add-on instead (developer disables it).
|
btw, |
Yeah, I split it off mozilla/addons#16532 since the design's more involved |
Yeah, you can see it here. For disable, it's on the detail page here |
eviljeff
left a comment
There was a problem hiding this comment.
Personally, I'm not really convinced that showing the add-on wide visibility (disable) toggle next to a single version makes conceptual sense, but that does seem to be what UX/Product have designed so I'll defer to their expertise.
Just the font question.
| ? html`<button class="toggle" popovertarget="popover">${badge}</button>` | ||
| : badge | ||
| } | ||
| <div id="popover" class="popover" popover> |
There was a problem hiding this comment.
See moz-panel; http://localhost:6006/?path=/docs/components-panellist--docs

Fixes mozilla/addons#16505
Description
Adds version list in Pinguino.
Testing
Navigate to
developers/addon/<slug>/versionsin Pinguino, after settingVITE_AMO_SESSION_ID. Should be able to:Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.