feat(lint): Replace black, isort, and flake8 with ruff#797
Merged
Conversation
hneiva
force-pushed
the
hneiva/ruff-linting
branch
from
3990893 to
049a98f
Compare
hneiva
changed the title
Contributor
Author
|
I did my best to review the function docs/explanations that claude generated. I'm happy to adjust if anyone thinks it's not good enough. |
Eijebong
previously requested changes
May 18, 2026
Contributor
Eijebong
left a comment
Eijebong
left a comment
There was a problem hiding this comment.
Would look better without the claude-isms.
The `tox -e check` env now runs `ruff check` + `ruff format --check`; `pyproject.toml` carries a single `[tool.ruff]` block in place of `[tool.black]` and `[tool.isort]`; the `[flake8]` section in tox.ini is removed. Also fixes 18 pydocstyle (D-rule) violations that flake8_docstrings had been silently ignoring (the plugin was effectively a no-op without an explicit docstring-convention setting). One-time `ruff format` pass touched 7 files with cosmetic-only changes (long-call wrapping, implicit-string collapsing).
hneiva
force-pushed
the
hneiva/ruff-linting
branch
from
049a98f to
64d49ea
Compare
bhearsum
approved these changes
May 20, 2026
Contributor
bhearsum
left a comment
bhearsum
left a comment
There was a problem hiding this comment.
In the future please separate out the tool change from the reformatting into separate commits for ease of review.
This is the second (I think?) repository these changes have happened in. It would be good to codify this in https://github.com/mozilla-releng/reps at some point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tox -e checkenv now runsruff check+ruff format --check;pyproject.tomlcarries a single[tool.ruff]block in place of[tool.black]and
[tool.isort]; the[flake8]section in tox.ini is removed.Also fixes 18 pydocstyle (D-rule) violations that flake8_docstrings had been silently ignoring (the plugin was effectively a no-op without an explicit docstring-convention setting). One-time
ruff formatpass touched 7 files with cosmetic-only changes (long-call wrapping, implicit-string collapsing).