Bug 2044409 - Filter slider updates while Accessibility shouldUseAutoSize is false - #325
Closed
moztcampbell wants to merge 1 commit into
Closed
Bug 2044409 - Filter slider updates while Accessibility shouldUseAutoSize is false#325moztcampbell wants to merge 1 commit into
moztcampbell wants to merge 1 commit into
Conversation
…Size is false The engine code doesn't allow setting a fontSizeFactor when auto-sizing is enabled. We previously tried to disable the Slider that updates the size factor in order to prevent update messages, but the disable doesn't take effect until next recomposition. As a result we see crashes in monkey testing which adds noise even if it is highly unlikely for a normal user to hit.
Contributor
|
View this pull request in Lando to land it once approved. |
lando-web
Bot
changed the title
Contributor
Author
|
[testing-other] This is a crash that was only triggered by monkey testing and would be clumsy to test in a repeatable way. |
|
Pull request closed by commit 28ea41d |
lando-worker Bot
pushed a commit
that referenced
this pull request
Aug 11, 2026
…Size is false r=ohall The engine code doesn't allow setting a fontSizeFactor when auto-sizing is enabled. We previously tried to disable the Slider that updates the size factor in order to prevent update messages, but the disable doesn't take effect until next recomposition. As a result we see crashes in monkey testing which adds noise even if it is highly unlikely for a normal user to hit. Pull request: #325
Contributor
|
Why, thanks @lando-web... Better late than never, huh? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine code doesn't allow setting a fontSizeFactor when auto-sizing is enabled. We previously tried to disable the Slider that updates the size factor in order to prevent update messages, but the disable doesn't take effect until next recomposition. As a result we see crashes in monkey testing which adds noise even if it is highly unlikely for a normal user to hit.