Fix MotionPlanning combo box signals for Qt6#3745
Open
andrearosasco wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the MotionPlanning RViz plugin's named-state combo box connections when built against Qt6.
Qt6 no longer exposes the old text-carrying
QComboBoxsignal names used by the plugin's string-based connections:activated(QString)currentIndexChanged(QString)In a Qt6 RViz environment this produces runtime warnings such as:
When those connections fail, selecting a named Start State or Goal State in the MotionPlanning panel does not invoke the corresponding handler, so selecting a named goal such as
homedoes not update the query goal state.For more details check #3744
Changes
QComboBox::textActivatedfor Start State and Goal State under Qt6.QComboBox::currentTextChangedfor Planning Group under Qt6.Testing
Tested downstream in a RoboStack Lyrical Qt6 RViz environment by rebuilding
moveit_ros_visualizationwith this patch and verifying that the MotionPlanning panel no longer logs the missingQComboBoxsignal warnings and named goal-state selection works again.