fix: strip trailing slash from endpoint in Search#14
Merged
Conversation
The ingest path (built in loop) already called strings.TrimSuffix on the endpoint before appending "/ingest", but Search used c.endpoint+"/search" directly. A caller who passes an endpoint with a trailing slash would get a double-slash URL (e.g. /api/v1/index//search) that servers and proxies commonly reject with 404 or 400. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Searchbuilt its URL asc.endpoint+"/search"without first stripping a trailing slash, producing…/index//searchwhen the caller passes a trailing-slash endpoint.loop) already appliesstrings.TrimSuffix(endpoint, "/")correctly. This bringsSearchin line with that convention.Test plan
TestSearch_TrailingSlashEndpoint— passes a trailing-slash endpoint and asserts the captured server path contains no//and ends with/searchgo test ./...passes🤖 Generated with Claude Code