Not detected as affected when PNPM catalog is edited

[d-corler]

Thanks for the support of the pnpm catalog introduced with #88.

In a context of dependency bump automation (renovate, ...), versions defined in the catalog are edited, as well as the lock file : should I expect to see projects using bumped dependencies as affected ?

The package.json is set as implicitInputs of the node toolchain in my projects.

---

Example:

# ./pnpm-workspace.yaml

packages:
  - packages/*

catalog:
-  remeda: 2.32.1
+  remeda: 2.32.2

# .moon/tasks/node.yml

implicitInputs:
  - package.json

# ./packages/ts-json/moon.yml
id: ts-json
language: typescript
platform: node
tags:
  - tsdown
layer: library

# ./packages/ts-json/package.json
{
	"name": "test/json",
	"version": "1.0.0",
	"type": "module",
	"dependencies": {
		"remeda": "catalog:"
	}
}

❯ moon task ts-json:build                                         
About ────────────────────────────────────────────────────────

  Target: ts-json:build
  Project: ts-json
  Task: build
  Toolchains: node, typescript
  Type: build
  Depends on:
    - [...]

Process ──────────────────────────────────────────────────────

  Command: pnpm exec tsdown
  Environment variables: —
  Working directory: /[...]/packages/ts-json
  Lookup paths: —
  Runs dependencies: Concurrently
  Runs in CI: Yes

Configuration ────────────────────────────────────────────────

  Inherits from:
    - .moon/tasks/tag-tsdown.yml
  Inputs:
    - .moon/*.{pkl,yml}
    - .moon/tasks/tag-tsdown.yml
    - packages/ts-json/package.json
    - packages/ts-json/src/**/*
    - packages/ts-json/tsdown.config.*
  Outputs:
    - packages/ts-json/lib/**/*

❯ moon query projects --affected --downstream deep --json         
{
  "projects": [], <-- ❓❓ How can I retrieve projects affected by this dependency bump ?
  "options": {
    "affected": {
      "shouldCheck": false
    },
    "json": true,
    "query": null,
    "alias": null,
    "id": null,
    "language": null,
    "layer": null,
    "stack": null,
    "source": null,
    "tags": null,
    "tasks": null
  }
}

[milesj]

Since the actual change is in the pnpm config file, that file would also need to be in implicitInputs. Right now, moon has no context where the catalog entries are coming from.

[d-corler]

Do you mean adding pnpm-workspace.yaml as an implicitInputs ?

# .moon/tasks/node.yml

implicitInputs:
  - package.json
  - /pnpm-workspace.yaml

[milesj]

Yeah

[d-corler]

So I have an issue with my configuration. I set implicitInputs as described, but no matter what I do in pnpm-workspace.yaml, projects are not marked as affected.

Example:

# ./pnpm-workspace.yaml

packages:
  - packages/*

catalog:
-  remeda: 2.32.1
+  remeda: 2.32.2

# .moon/tasks/node.yml

implicitInputs:
  - package.json
  - /pnpm-workspace.yaml

# packages/my-project/moon.yml

id: my-project
language: typescript
platform: node
tags:
  - tsdown
layer: library

❯ moon task my-project:build
About ────────────────────────────────────────────────────────────────────────────────────────────────────────

  Target: my-project:build
  Project: my-project
  Task: build
  Toolchains: node, typescript
  Type: build
  Depends on:
    - [...]

Process ──────────────────────────────────────────────────────────────────────────────────────────────────────

  Command: pnpm exec tsdown
  Environment variables: —
  Working directory: /[...]/packages/ts-json
  Lookup paths: —
  Runs dependencies: Concurrently
  Runs in CI: Yes

Configuration ────────────────────────────────────────────────────────────────────────────────────────────────

  Inherits from:
    - .moon/tasks/tag-tsdown.yml
  Inputs:
    - .moon/*.{pkl,yml}
    - .moon/tasks/tag-tsdown.yml
    - packages/my-project/package.json
    - packages/my-project/src/**/*
    - packages/my-project/tsdown.config.*
    - pnpm-workspace.yaml
  Outputs:
    - packages/my-project/lib/**/*

❯ moon query projects --affected --json
{
  "projects": [],
  "options": {
    "affected": {
      "shouldCheck": false
    },
    "json": true,
    "query": null,
    "alias": null,
    "id": null,
    "language": null,
    "layer": null,
    "stack": null,
    "source": null,
    "tags": null,
    "tasks": null
  }
}

[milesj]

@d-corler If this is local, the pnpm-workspace.yaml file must be changed and in git status for affected to trigger. In CI, it uses git diff and compares across branches.

[d-corler]

Well noted, I tried both methods you suggested.

With pnpm-workspace.yaml in staged changes, I don't have affected projects.

Same when I commit the change within a feature branch.

diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
index b27e6bf7..e47558bb 100644
--- a/pnpm-workspace.yaml
+++ b/pnpm-workspace.yaml
@@ -18,7 +18,7 @@ catalog:
   rxjs: 7.8.2
-  tsdown: 0.19.0-beta.3
+  tsdown: 0.19.0
   type-fest: 5.3.1
   typescript: 5.9.3

MOON_BASE=main moon query projects --affected
# Empty result

However, if I use task query, I have expected projects as affected.

MOON_BASE=main moon query tasks --affected --json

{
  [...]
  "options": {
    "affected": {
      "projects": {
        "ts-json": {
          "tasks": [
            "ts-json:format",
            "ts-json:test-cov",
            "ts-json:test-watch",
            "ts-json:prepare",
            "ts-json:cleanup",
            "ts-json:typecheck",
            "ts-json:lint",
            "ts-json:publish",
            "ts-json:dev",
            "ts-json:build",
            "ts-json:format-write",
            "ts-json:test"
          ],
          "other": false
        }
        [...]
      }
    }
  }
}