Skip to content

[skia-sync] Merge upstream chrome/m152 - #331

Closed
mattleibow wants to merge 330 commits into
skiasharpfrom
skia-sync/m152-mattleibow-dev-vulkan-sync-validation
Closed

[skia-sync] Merge upstream chrome/m152#331
mattleibow wants to merge 330 commits into
skiasharpfrom
skia-sync/m152-mattleibow-dev-vulkan-sync-validation

Conversation

@mattleibow

@mattleibow mattleibow commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Description

Automated upstream merge of chrome/m152.

This pull request was produced by skia-upstream-sync.

SkiaSharp issue

N/A — automated upstream synchronization.

Required SkiaSharp PR

Requires mono/SkiaSharp#4636

Areas affected

  • C API (include/c, src/c)
  • Native dependency / DEPS
  • Build (gn / build files)
  • Upstream Skia merge or rebase
  • Rendering output / behavior
  • Other

Changes

Merge Chrome milestone m152 into the skiasharp fork of mono/skia.

  • Upstream ref: chrome/m152 @ 2a9b593bab4b2fd019fa494c8d401ff1fab0b883 (previous base 755b89e0).
  • Two-parent merge of upstream m152 onto fork base a0dd0727; merge commit 0c9242b6f3.
  • DEPS (preserved): fork curation kept — unused deps stay commented (highway, libjxl, swiftshader, vulkan-deps, spirv-*, vulkan-tools, vulkan-utility-libraries, angle2, dawn, abseil); fork security pins kept (brotli, expat, freetype, harfbuzz 56feae40, libpng, libwebp, vulkan-headers). CI-infra vars adapted from upstream.
  • VulkanMemoryAllocator rolled 3.2.13.4.0 (eb744ea7, matches upstream m152) in a dedicated submodule commit ff69e4a418. Required because VulkanAMDMemoryAllocator.cpp now needs VmaAllocationCreateInfo::minAlignment and vkGetPhysicalDeviceProperties2, absent from 3.2.1.
  • C API fix (src/c/gr_context.cpp, commit d840f796fd): gr_direct_context_make_vulkan[_with_options] now build a default VMA-backed allocator via skgpu::VulkanMemoryAllocators::Make when the caller passes a null fMemoryAllocator. Upstream m152 removed GrVkGpu::Make's internal auto-allocation (commit 5e183e5aea), so without this the Ganesh Vulkan context returns null. Mirrors the existing Graphite Vulkan C API path.
  • Fork-patch audit: 1 removed (upstreamed D3D guard), 7 changed (all dispositioned: DEPS preserved, go.mod/go.sum disable intent preserved, DawnCaps emdawnwebgpu patch reapplied, gr_context.cpp new VMA fallback preserved), 0 added. Gate passed.
  • No generated-binding signature changes (regeneration produced no diffs).

Submodule head: d840f796fd02a3d9375efea9d1a7feead2b2eec2.

Testing

Native library built from the merged m152 source tree (libSkiaSharp.so.152.0.0, Linux/x64). SkiaSharp full unfiltered test solution (net10.0, x64) against the freshly built native:

  • SkiaSharp.Tests: 6084 passed / 33 skipped
  • SkiaSharp.Vulkan.Tests: 23 passed / 2 skipped (declared platform skips: ganesh-vulkan-sharpvk not required on Linux)
  • SkiaSharp.Direct3D.Tests: 2 passed / 3 skipped (D3D not available on Linux — declared)
  • SkiaSharp.Tests.SingletonInit: 1 passed

GPU backends executed on Linux/x64: lavapipe Vulkan 1.4 ICD + softpipe GL 3.3. No required backend was skipped. Overall exit code: 0.

Human review

  • Cross-platform coverage: only Linux/x64 was built and tested locally. macOS (Metal), Windows (D3D), Android, iOS, and WebAssembly need CI verification.
  • Confirm the VMA 3.2.13.4.0 roll and the Ganesh Vulkan VMA-fallback C API change against any downstream consumers relying on the old null-allocator behavior.

Checklist

  • Targets the skiasharp branch
  • Changes above lists every added/changed C API export or states that none changed
  • Companion mono/SkiaSharp PR linked above

Last rendered by the sync workflow: 2026-08-03T02:50:06Z

recipe-roller and others added 30 commits July 7, 2026 08:59
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8676926301384728961

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/8b87a40e39bcc11174b8fc9033866fcca2a4f040
  8b87a40 (olivernewman@google.com)
      [luci_config] Implement fetching by signed URL

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3d4c0da4f0b1865b6651c4e1cc51d516ad3d6898
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1287356
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/abeb70d7ee3c..f79b8eaae53b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC egdaniel@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: egdaniel@google.com
Change-Id: Ia7757bf6fa3ca0d834ac40ad7a43778805809549
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1287298
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
BUG=502195264

Change-Id: I9611ca3b8060125e5d318fec05f1beffad340924
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1279536
Auto-Submit: Elliot Sisteron <elliotsisteron@google.com>
Reviewed-by: Florin Malita <fmalita@google.com>
Commit-Queue: Florin Malita <fmalita@google.com>
`recordBackwards` becomes `searchBackwards` and returns the Layer and
BindingList that the Draw should be added to. `recordForwards` is
renamed `findOrCreateBindingInLayer` to emphasize it's only used after
the pilot draw.

The `Draw` creation logic is handled in `recordDraw` after the final
BindingList is found. Splits Layer::add() into a `addNewBinding()`
function on Layer for creating and inserting new BindingLists and a
separate BidningList::addDraw() for inserting the Draw into a
BindingList.

Bug: 419535595
Change-Id: Ic8b52ca9047f6094e6b526b891846953286973e2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1283258
Reviewed-by: Thomas Smith <thomsmit@google.com>
This avoids generating a fresh semi-long string for each DrawPass's
trace event and having to copy said string with TRACE_STR_COPY.
Hopefully it reduces the claimed CPU time spent in Recorder::snap().

Change-Id: I3ac46903656f6f5e34dec118a92a66792d72143c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1283357
Commit-Queue: Noelle Scobie <nscobie@google.com>
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Noelle Scobie <nscobie@google.com>
When deserializing an SkDescriptor in MakeFromBuffer, we
must validate that the length is a multiple of 4
(SkIsAlign4). Otherwise, passing an unaligned length to
SkAutoDescriptor triggers an assertion failure/abort
inside SkDescriptor::Alloc.

Bug: b/524792615
Test: skia_unittests --gtest_filter="Descriptor*"
Change-Id: Id3db0fb85c8baa50db617ff93bf34f1d6be0a471
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1287596
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Tzarial <zork@google.com>
I was unable to reproduce the linked bug, but the defense-in-depth
is very easy to add, so let's do that math that might overflow
in 64 bit before it gets shifted back down into a definitely safe
range.

While tracing this, I found some runtime asserts that can be
compile time static_asserts and fixed those.

Change-Id: I3ca28f236d078612d2a5e27e8098a48b05fccae4
Bug: 514122986
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1282077
Commit-Queue: Alexis Cruz-Ayala <alexisdavidc@google.com>
Auto-Submit: Kaylee Lubick <kjlubick@google.com>
Reviewed-by: Alexis Cruz-Ayala <alexisdavidc@google.com>
While dealing with a bug in this code, I came back to some comments
I left unfinished and filled out the explanations a bit.

Change-Id: I6ef6cc29a8c3cdee61bec919e12605d1626a96a2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1283276
Commit-Queue: Alexis Cruz-Ayala <alexisdavidc@google.com>
Reviewed-by: Alexis Cruz-Ayala <alexisdavidc@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8676905538373604225

depot_tools:
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/31c35031c865291f82de035093b6ccb5e6751671~..f8b43ac95d4fa826b01f4c63da915093518b1bb4
  31c3503 (ovsienko@google.com)
      Ruff: make myself the owner of the upcomig ruff formatter files.
  f8b43ac (bpastene@chromium.org)
      Add fallback to different gerrit frontends in get_changes() rec...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: If3ab40616e149cc245f778152ef19e74248a3fe2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1287836
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8676901128255099969

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+log/4097ed6cc441f3b4bbdfe7561f729489c641791b~..39e7ea04d93fa0ff59122415dfb4d04d1b9f3fb8
  4097ed6 (iannucci@google.com)
      Import all upstream TurboCI helper libraries to the recipe engine.
  39e7ea0 (iannucci@google.com)
      Add additional python libraries needed to work with gRPC status...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4c493b699277ee267dc97893bb93f40db64760ec
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1287937
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
https://swiftshader.googlesource.com/SwiftShader.git/+log/eb0bee078ef2..a7c547b55474

2026-07-07 ted.lin0000@gmail.com Vulkan: Build Wayland WSI against libwayland older than 1.20

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC bsalomon@google.com,egdaniel@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Ubuntu24.04-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: egdaniel@google.com
Change-Id: Ie369bfa84465647c6baae2de55102d233d07af93
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1288079
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://dawn.googlesource.com/dawn.git/+log/6bcedae5720d..0b1713dac2c2

2026-07-08 stevenperron@google.com Refactor process in DecomposeStridedMatrix
2026-07-07 kainino@chromium.org [docs] Update some development tips
2026-07-07 kainino@chromium.org Fix some loud clang-tidy warnings
2026-07-07 dsinclair@chromium.org Switch OWNERS entry to chromium email.
2026-07-07 amaiorano@google.com [native] Eagerly clear destroyed textures in ResourceTable slots
2026-07-07 kainino@chromium.org Use C++20 explicit(false) instead of NOLINT where possible
2026-07-07 chouinard@google.com [cts] Suppress test failing on Pixel 4 on CI
2026-07-07 alanbaker@google.com [wgsl][ir] Restrict buffer sizes
2026-07-07 chouinard@google.com [cts] Suppress flaky AMD Mac tests
2026-07-07 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 23f150c5eb97 to 4ffee2801567 (714 revisions)
2026-07-07 kainino@chromium.org [utils] Re-enable -Wunsafe-buffer-usage, add tests
2026-07-07 chouinard@google.com Allow all to update chromium-tools-build gitlink
2026-07-07 chouinard@google.com Remove dawn_build_litert_lm gn arg
2026-07-07 chouinard@google.com Disable SwiftShader Wayland build by default
2026-07-07 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 245a3bb1956d to eb42fc724f0a (56 revisions)
2026-07-07 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 7868bf37d5b2 to eb0bee078ef2 (1 revision)
2026-07-07 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from 3fe4b7da73b4 to 43546e578e6a (2 revisions)
2026-07-07 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c053bf85793b to 1dec433b7f49 (18 revisions)
2026-07-07 kainino@chromium.org Add script to run clang-tidy over all code

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC chouinard@google.com,cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac14-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11
Bug: None
Tbr: chouinard@google.com
Change-Id: Ideaaba577638cda872cfbfd3ebb30c8b54036796
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1287719
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://skia.googlesource.com/buildbot.git/+log/dc5c43ee2e11..fe8945d89a4c

2026-07-07 louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com Toggle Perfserver Freeze - on - perf/FREEZELOCK
2026-07-07 mordeckimarcin@google.com Align android and widevine-cdm issuetracker config
2026-07-07 sruslan@google.com Improve fuzzy matching for dot-separated names and boost key types.
2026-07-07 sruslan@google.com Support formula chaining pipelines and dark mode fixes in Explore Multi V2
2026-07-07 sergeirudenkov@google.com add option to switch to postgres12
2026-07-07 mordeckimarcin@google.com [perf] Refactor FileBug in issuetracker to improve readability
2026-07-07 mordeckimarcin@google.com [perf] Refactor FileBug and FileUserIssue to use CreateIssue
2026-07-07 sruslan@google.com Handle null/undefined values in cluster regression responses.
2026-07-07 sergeirudenkov@google.com infra: Define temporal-ui target in temporal/BUILD.bazel
2026-07-07 sruslan@google.com Show loading state and stale counts in query bars.
2026-07-07 sergeirudenkov@google.com update temporal to 1.24.2
2026-07-07 mordeckimarcin@google.com [perf] Refactor culprit package to use shared IssueTracker
2026-07-07 mordeckimarcin@google.com [perf] Refactor notify package to use shared IssueTracker
2026-07-07 mordeckimarcin@google.com [perf] Always initialize IssueTracker if configured
2026-07-07 mordeckimarcin@google.com [perf] Add low-level methods to IssueTracker
2026-07-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-final from 988d69c35c2f to 8a97ef67f546
2026-07-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Depot Tools from 328304459306 to 23ed94f58480 (4 revisions)
2026-07-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll command_wrapper from 6137f0fd1f669c4d0... to d09f23c954a0d699b... (1 revision)
2026-07-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-final from 62fda2b4cd39 to 2cb8093cd06b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/infra-skia
Please CC borenet@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:532001307,chromium:532004967
Tbr: borenet@google.com
Change-Id: I187e4b490d0b37fdc08560f3b1c32d0c17fdaf98
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1288116
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/angle/angle.git/+log/1bb9d6a05849..d3728521450c

2026-07-08 kyongjoo.oh@samsung.com OpenCL: Fixes to DescriptorSetReuse feature
2026-07-07 rafael.cintron@microsoft.com DirectX9 Backend Removal: Remove shader translator code
2026-07-07 rafael.cintron@microsoft.com D3D11: Remove attributeZeroRequiresZeroDivisor limitation
2026-07-07 cclao@google.com Vulkan: fix VkQueue creation with GLOBAL_PRIORITY_REALTIME_EXT
2026-07-07 lexa.knyazev@gmail.com PLS: Use internal API for setting default dimensions
2026-07-07 lexa.knyazev@gmail.com Refactor PolygonMode validation
2026-07-07 wangra@google.com Validate sub-image update type against allocated texture format
2026-07-07 lexa.knyazev@gmail.com Remove redundant functions from Context
2026-07-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 7868bf37d5b2 to eb0bee078ef2 (1 revision)
2026-07-07 zork@google.com Fix VRAM leak in D3D11 cube map redefinition
2026-07-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8e7420f63043 to 08c031d6c089 (12 revisions)
2026-07-07 lexa.knyazev@gmail.com Remove NV suffix from some internal functions
2026-07-07 lexa.knyazev@gmail.com Fix FramebufferTexture2DOES validation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC egdaniel@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win11-Clang-Dell3930-GPU-GTX1660-x86_64-Debug-All-ANGLE
Tbr: egdaniel@google.com
Test: Test: angle_end2end_tests --gtest_filter=
Test: Test: angle_end2end_tests --gtest_filter=CubeMapTextureTest.RedefineSiblingFace*
Change-Id: I08cbc6b28dab06a24ebd77b2bb37ae92372a9635
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1288076
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/f79b8eaae53b..bbc872ec2e93

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC egdaniel@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: egdaniel@google.com
Change-Id: I0ac0e92da6530c8674d9a43d5a4c19b00b8032d8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1288136
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8676870306902561537

depot_tools:
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/020e532ce1cf45f00a76f85c8c1c650b6b7cd867
  020e532 (ovsienko@google.com)
      ruff: create wrapper script for ruff.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifdac03644fa199b0cf3e9f0784658d324d8b44a9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1288216
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
We'd been hardcoding paths like external/+_repo_rules2+clang_mac
which are new with BzlMod to avoid issues where different packages
depend on different versions of a dependency. We weren't supposed
to rely on this exact name resolution being the same across Bazel
releases, but we were. This is fragile as things are added to
MODULE.bazel and hasn't broken yet, but was getting annoying as I
was adding support for Windows.

This uses repo_name [1] to resolve that properly. We need to pipe
through something with a label from the toolchain to achieve this,
thus the references to ...compile_files.

[1] https://bazel.build/rules/lib/builtins/Label#repo_name

Bug: b/256860816, b/256860364
Change-Id: Ic8b18544e17944db368e35c2c78b77918155f4df
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1287856
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kaylee Lubick <kjlubick@google.com>
Addresses a warning as error (unique-object-duplication) that arises because the inline functions defined in Test.h use a macro (TRACE_EVENT1) that expands into `static std::atomic`. Mac's compiler doesn't like static variables in inline functions with hidden visibility.

Bug: 480952153

Change-Id: Ib605a1e2274cda125d872d8e51c1d5a9be73efcf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1287397
Commit-Queue: Jorge Betancourt <jmbetancourt@google.com>
Reviewed-by: Kaylee Lubick <kjlubick@google.com>
skia_flags_defaults be used in ag/40819920 (WIP CL) to avoid inheriting
the srcs.

BUG=529738725

Change-Id: I8cc6e8bad27e4b403efdb5e7a823af5e4ed644bd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1287027
Reviewed-by: Florin Malita <fmalita@google.com>
Commit-Queue: Elliot Sisteron <elliotsisteron@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8676826262244165137

depot_tools:
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/93d193dc821a0a738d747d3ed481a0d668dd240d
  93d193d (akhoroshilov@brave.com)
      Allow JS/TS formatter to be disabled with --no-js flag to git c...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8e7ad5dae223805efed6ff6643484c961437c7b9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1288816
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Make the SkData object (fData) within the UrlDataManager and UrlData classes const. This prevents the editing of the underlying data in the cache.

Change-Id: Id8e7b32fa13f039eecf527e5f6f2a9f7c8b8375c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1287516
Commit-Queue: Alexis Cruz-Ayala <alexisdavidc@google.com>
Reviewed-by: Kaylee Lubick <kjlubick@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8676821862510915233

depot_tools:
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/849d4d2609d3609474d7501c78babbab193afb13~..298c0d8f48eb016509cd104013d625f5e084f465
  849d4d2 (ovsienko@google.com)
      ruff: owners in tests is its own file.
  298c0d8 (jochen@chromium.org)
      Clarify diff.ignoreSubmodules warning.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iaebececf6d5a88c541b837c851e5e931373cf226
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1288801
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/bbc872ec2e93..8ef965cdf8d0

Also rolling transitive DEPS:
  https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/02c0394e57af6dfdda7f68973df6aa20fc3f5def..29981f65241605e08b0ede4cfeb999fe3b723c6a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC egdaniel@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: egdaniel@google.com
Change-Id: I6670a4a8435b00a3e12cd4c233d3ed358e4cc0fd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1288299
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Instead of passing an empty SkSerialProcs struct, create one that encodes images as pngs to SkBinaryWriteBuffer

Change-Id: Icaf529db67f3f46c8e4e454b50b704c1e13a5780
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1279256
Reviewed-by: Kaylee Lubick <kjlubick@google.com>
Commit-Queue: Alexis Cruz-Ayala <alexisdavidc@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8676813054647902433

depot_tools:
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/8e9d7ec8680fb69bcd7c12d3888a517d756b1132
  8e9d7ec (leszeks@chromium.org)
      [gerrit] Support 'is_ai' in comment API when running inside an...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib67e878f6827fc3ae52f3b85dab081f64d2cce11
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1288996
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
…eps in reverse order

Searching from the last RenderStep and inserting in reverse order allows
the directional template parameter to searchBinding to be removed (less
code size). Having the last step be the pilot draw for multi-step
renderered draws is also advantageous because that is typically the
shading step, which will have more constrained binding requirements. The
remaining steps that are usually stencil-only will then match in bulk in
the found layer.

This also sets up the BindingList linked-list on Layer to be organized
into two sections, a first "half" for non-shading draws (which can
include the stencil steps of a shaded renderer), and then a second
"half" for shading draws. In later CLs this will be used to end
iterating over the Layer's lists when possible.

Bug: 419535595
Change-Id: I04122548e0d68890c5e7d702003a3f5d82a8609e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1283277
Reviewed-by: Thomas Smith <thomsmit@google.com>
Commit-Queue: Thomas Smith <thomsmit@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8676808647999274305

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+log/d16f811d8b1a30274ec53d23765c42514aa7ba0b~..28a53f0037fdfecb32ca7da1fc7056e023f04594
  d16f811 (iannucci@google.com)
      Replace recipe-py turboci ids library with upstream one.
  28a53f0 (iannucci@google.com)
      Remove run_transaction.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib92844d2b71d8c3cd409d57123e2004b6d7d0e0e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1289096
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8676804245364766337

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/f89a67b7a54153cfb0beaafcafb993a1d9181f99
  f89a67b (iannucci@google.com)
      Rework exceptions to be based on upstream client.RPCError.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: If447092f3418c7c3946b18bbe49244d6c1275914
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1289116
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools, recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8676796696968420817

depot_tools:
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/746ce6c76523a59cfc3c3c50e9ae23f487388aba
  746ce6c (ovsienko@google.com)
      ruff: add test file for the ruff wrapper.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/e948ce612498e549614884b9f9f3fdcecab65035
  e948ce6 (iannucci@google.com)
      [TurboCI] Import latest protos.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I40b0c5a10d5891a0cee3c35708385a415ada1e5f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1289256
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
https://dawn.googlesource.com/dawn.git/+log/0b1713dac2c2..44d9faab2712

2026-07-09 dneto@google.com typed integer tests: in release ubsan builds, skip test
2026-07-09 bajones@chromium.org Conform with -Wsign-conversion, part 2
2026-07-09 kainino@chromium.org [dawn] Replace some raw allocations with HeapArray
2026-07-09 lokokung@google.com [wire] Separate the client Device alive state into lost and destroyed.
2026-07-08 lokokung@google.com [wire] Fix potential lock inversion in buffer mapping.
2026-07-08 kainino@chromium.org Revert "[github] Enable TINT_ENABLE_INSTALL on CI"
2026-07-08 rharrison@chromium.org [infra] Normalize how absl is accessed in GN targets
2026-07-08 dsinclair@chromium.org Move more validation to functional
2026-07-08 kainino@chromium.org [utils] Add HeapArray
2026-07-08 lokokung@google.com [utils] Add ReinterpretSpan helper for Spans.
2026-07-08 dsinclair@chromium.org Add check for backend specific shader IO.
2026-07-08 angdaniel@google.com [spanify] Rewrite raw arrays to std::array in Dawn
2026-07-08 bajones@chromium.org Conform with -Wsign-conversion, part 1
2026-07-08 stevenperron@google.com Decompose matrix function parameters
2026-07-08 kainino@chromium.org Fix remaining explicit-constructor warnings
2026-07-08 kainino@chromium.org [docs] Fix d3d path for .clangd
2026-07-08 rharrison@chromium.org [infra] Use hermetic version of llvm-dev
2026-07-08 stevenperron@google.com Avoid access instruction with no index
2026-07-08 stevenperron@google.com tint/spirv: Refactor constant rewriting in transpose row major
2026-07-08 stevenperron@google.com Fix glob.Scan to work in git worktrees
2026-07-08 stevenperron@google.com [ir] Validate matrix attributes on struct members
2026-07-08 chouinard@google.com [cts] Suppress test failing on Pixel 10 CI
2026-07-08 alanbaker@google.com [spirv][vulkan] Enable reconvergence modes
2026-07-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from eb42fc724f0a to b21bf6e50934 (9 revisions)
2026-07-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from 43546e578e6a to a7af79a5c5c9 (3 revisions)
2026-07-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 4ffee2801567 to ad6fea9acaca (820 revisions)
2026-07-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from eb0bee078ef2 to a7c547b55474 (1 revision)
2026-07-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 1dec433b7f49 to 5574b3f85e71 (12 revisions)
2026-07-08 chouinard@google.com [infra][bazel] Enable Tint bazel build bots on CQ
2026-07-08 chouinard@google.com [infra][bazel] Fix file inclusion list

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC cwallez@google.com,kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac14-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11
Bug: None
Tbr: kainino@google.com
Change-Id: Ie738f290f58b5ef04abd27855c0fecf6cadef8fc
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1289336
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
ArthurSonzogni and others added 22 commits July 24, 2026 12:52
Exclude pointers to global/static state. These have zero UAF risk.
Exclusion avoids runtime overhead and ensures static tables containing
these pointers can remain compile-time constant-initialized with trivial
destructors.

Bug: 351867706
Change-Id: Ia333d3b0682b783b7e98b7d18aa5216a49d33f7d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1290298
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Kaylee Lubick <kjlubick@google.com>
Reviewed-by: Kaylee Lubick <kjlubick@google.com>
…ic state"

This reverts commit e49f657.

Reason for revert: it breaks the tree.


Original change's description:
> miracleptr: Add RAW_PTR_EXCLUSION for pointers to global/static state
>
> Exclude pointers to global/static state. These have zero UAF risk.
> Exclusion avoids runtime overhead and ensures static tables containing
> these pointers can remain compile-time constant-initialized with trivial
> destructors.
>
> Bug: 351867706
> Change-Id: Ia333d3b0682b783b7e98b7d18aa5216a49d33f7d
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1290298
> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
> Commit-Queue: Kaylee Lubick <kjlubick@google.com>
> Reviewed-by: Kaylee Lubick <kjlubick@google.com>

Bug: 351867706
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I53f682ebd4004448fe6042a05743930ec4a481ed
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1303776
Commit-Queue: Julia Lavrova <jlavrova@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Change-Id: I1df6029886df468df480ec43e9e2ca46ce5e5ad9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1303336
Reviewed-by: Julia Lavrova <jlavrova@google.com>
Reviewed-by: Kaylee Lubick <kjlubick@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Manual roll requested by robertphillips@google.com

https://chromium.googlesource.com/angle/angle.git/+log/e316181208fd..92de898b7a32

2026-07-24 syoussefi@chromium.org Fix YUV target validation of color attachment index
2026-07-24 syoussefi@chromium.org Skip flaky no-storage-image-bound test more broadly
2026-07-24 jisunnie.lee@samsung.com Add program binary blob compression/decompression
2026-07-24 syoussefi@chromium.org Skip flaky test on Mac/Intel/Metal
2026-07-24 cclao@google.com Vulkan: Properly handle tile memory allocation failure
2026-07-24 syoussefi@chromium.org Skip flaky no-storage-image-bound test
2026-07-24 syoussefi@chromium.org WebGPU: Disable tests on Mac/AMD
2026-07-24 lehoangquyen@chromium.org Metal: Fix index buffer rewriting OOB write and rendering bug
2026-07-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from afc9d8707b53 to 808860b25bf7 (4 revisions)
2026-07-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from f24f519928ff to d6a338e7de51 (793 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC jlavrova@google.com,jmadill@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win11-Clang-Dell3930-GPU-GTX1660-x86_64-Debug-All-ANGLE
Tbr: jlavrova@google.com,robertphillips@google.com
Change-Id: I2b0852dedd91becca06de51e96dff6e2a69041cb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1303656
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/1f2cbadfb9c8..8e393ad533ce

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC jlavrova@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: jlavrova@google.com
Change-Id: I8dd4bfd7eaad13f3eaa02fa0d41c2c7cf2ec086d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1304076
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/8e393ad533ce..59e03a8479a3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC jlavrova@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: jlavrova@google.com
Change-Id: Ieb4299f39894f039b56c70713f83b099a3d2b75b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1304236
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skp-skia
Please CC bwils@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SKP CIPD package: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: bwils@google.com
Change-Id: I214f5505e00eef5a632d411dc943332d69f11418
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1304396
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/59e03a8479a3..f147dcdbea36

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC bwils@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: bwils@google.com
Change-Id: Ibdf918d8e84cdfabc363dac7d16634c3d5116926
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1304496
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8675160917345702769

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/faf7c220fe1ffa1d71e8d69fdc45c5eb5796e265
  faf7c22 (fancl@chromium.org)
      fix rmtree on windows

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6c6694a76e38aa4d994be673552017caab091ac3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1304596
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/debugger-app-base-skia
Please CC borenet@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: borenet@google.com
Change-Id: Iee2f563088d4f22bd1056d1964c37216b1d8eeaa
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1304716
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://dawn.googlesource.com/dawn.git/+log/a56ab87a19a0..1e897275172a

2026-07-24 lokokung@google.com [wire] Remove deprecated wire APIs in favor of volatile versions.
2026-07-24 lokokung@google.com [wire] Cpp-ify trivial functions which require just updating types.
2026-07-24 cwallez@chromium.org [dawn][d3d12] Fix or triage all DAWN_UNSAFE_TODOs
2026-07-24 cwallez@chromium.org [dawn][vk] Use the Span constructor from C style arrays.
2026-07-24 cwallez@chromium.org [dawn][native] Coalesce DAWN_UNSAFE_TODOs for fixed-extent spans.
2026-07-24 lokokung@google.com [wire] Cpp-ify the Dawn wire client API so that we can spanify.
2026-07-24 chouinard@google.com [vulkan] Avoid executing zero-sized draws calls
2026-07-24 kylechar@google.com Update device lock metric names
2026-07-24 bajones@chromium.org Vulkan: Pack correct stencilTestEnable state
2026-07-24 cwallez@chromium.org [dawn][node] Throw RangeError on oversized createResourceTable
2026-07-24 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from afc9d8707b53 to 808860b25bf7 (4 revisions)
2026-07-24 lokokung@google.com [wire] Add dawn::wire::client C++ structs to allow for spanification.
2026-07-24 cwallez@chromium.org [dawn][node] Align with the latest ResourceTable proposal
2026-07-24 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from 2fab3f175518 to 1f8a14aecd4f (1 revision)
2026-07-24 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2b6571f5ae43 to 63b429dc3887 (811 revisions)
2026-07-24 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 8521722b7ebc to e316181208fd (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-skia-autoroll
Please CC chouinard@google.com,cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac14-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win11-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11
Bug: None
Tbr: chouinard@google.com
Change-Id: I0ca2c1c0cd4b1008968827c639703830823cc95c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1304676
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/f147dcdbea36..70a303980973

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-skia-autoroll
Please CC bwils@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE
Bug: None
Tbr: bwils@google.com
Change-Id: I6144893fb4ebf6329b3d5d7411c9364ffc776c42
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1304577
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/angle/angle.git/+log/92de898b7a32..c3ede28106e9

2026-07-27 syoussefi@chromium.org Translator: Handle comma and ternary for array checks
2026-07-24 zychen2828@gmail.com IR: Validate no identity swizzles
2026-07-24 kbr@chromium.org GL: add mipmap generation and base level workaround.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC bwils@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Ubuntu24.04-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win11-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win11-Clang-Dell3930-GPU-GTX1660-x86_64-Debug-All-ANGLE
Tbr: bwils@google.com
Test: Test: angle_end2end_tests --gtest_filter="*Texture2DTestES3_NonZeroBaseLevelGenMipmaps*"
Change-Id: I40d8a170a93ab17c107b6f07f475e3f91e5161e7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1304617
Commit-Queue: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: skia-autoroll@skia-public.iam.gserviceaccount.com <skia-autoroll@skia-public.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8675150222341558497

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/b53d33619617ab41cefeecf850e688ab695e1073
  b53d336 (fancl@chromium.org)
      try fix rmtree on windows again

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6239230ec70ca7e87030ff0b66c7d87e6e799ec0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1304896
Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
* Prior to this change, conics were approximated with quadratics, now they are approximated with cubics using Floater's method, which provides a G1 approximation whose error decreases at n^6.

Before this change: 97/97 MB 3 2.15ms 2.19ms 2.19ms 2.25ms 1% ▂▁▄▁▅█▄▆▆▄
grmtl SparseStrips_Flatten_SIMD_Conics

After this change: 60/60 MB 5 1.07ms 1.09ms 1.08ms 1.1ms 1% ▁▅▃▅▁▆▄█▃▄
grmtl SparseStrips_Flatten_SIMD_Conics

Change-Id: I67cdccb88a497895334355ea39b1c2fe785e4f7b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1289176
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Thomas Smith <thomsmit@google.com>
Bug: none
Change-Id: I851496bacd72999ccd70884f418e697fb4888514
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1301398
Commit-Queue: Florin Malita <fmalita@google.com>
Reviewed-by: Florin Malita <fmalita@google.com>
Reviewed-by: Brandon Wilson <bwils@google.com>
Reviewed-by: Jorge Betancourt <jmbetancourt@google.com>
Change-Id: I5b17330d58a87e3f51b1d031b5fcd745e29f6e8f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1306896
Bot-Commit: chrome-branch-day <chrome-branch-day@chops-service-accounts.iam.gserviceaccount.com>
Change-Id: I0848942e368145e0e8e21440bff6927ef78b3097
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1306938
Bot-Commit: chrome-branch-day <chrome-branch-day@chops-service-accounts.iam.gserviceaccount.com>
Original change's description:
> Address incorrect handling of a map pointer in SkRP
>
> In pushChildCall, we held on to a pointer from a fChildEffectMap
> and then later dereferenced it. However, in between those
> points was a code path that could grow the map, invalidating
> the pointer. This is demonstrated in the newly added test.
>
> To fix it, we just dereference it earlier. While tracking this
> down, I found a suspicious other usage of the map which works
> in newer C++, but could break in older versions. It's trivial
> to fix Generator::writeFunction, so I handled that as well.
>
> Bug: b/540157141
> Fixed: 540157141
> Change-Id: I149b070c31d4cfefa65b30972f0b8b94441e66db
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1308776
> Reviewed-by: Jorge Betancourt <jmbetancourt@google.com>
> Commit-Queue: Kaylee Lubick <kjlubick@google.com>

(cherry picked from commit 5b90a36)

Bug: 541112105,b/540157141,540157141
Change-Id: I149b070c31d4cfefa65b30972f0b8b94441e66db
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1311137
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
…52-mattleibow-dev-vulkan-sync-validation

# Conflicts:
#	DEPS
#	RELEASE_NOTES.md
#	include/gpu/ganesh/GrDriverBugWorkaroundsAutogen.h
#	src/gpu/ganesh/gl/GrGLGpu.cpp
Upstream chrome/m152 authored src/gpu/vk/vulkanmemoryallocator/VulkanAMDMemoryAllocator.cpp
against a newer VMA API: it sets VmaAllocationCreateInfo::minAlignment and copies
vkGetPhysicalDeviceProperties2KHR into VmaVulkanFunctions. Both are absent from the
fork's pinned VMA 3.2.1 (c788c521), causing compile errors. Roll the fork pin to the
upstream m152 revision eb744ea7 (VMA_VERSION 3.4.0), which adds both members.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Skia m152 removed the auto-creation of a Vulkan memory allocator inside
GrVkGpu::Make (commit 5e183e5, 'Remove legacy_ganesh_vulkan target that
had VMA baked in'). Callers that pass a null fMemoryAllocator now get a
nullptr GrDirectContext instead of a working context.

Restore the historical behavior in gr_direct_context_make_vulkan[_with_options]
by building a default VMA-backed allocator when the caller supplies none,
mirroring the existing Graphite Vulkan C API path.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@mattleibow mattleibow added partner/agentic-workflows Issues and PRs created by SkiaSharp agentic workflows. type/milestone-bump Merges upstream Skia to a new Chrome/Skia milestone (SK_MILESTONE bump). type/milestone-sync Any upstream Skia sync PR (milestone bump, same-milestone bug-fix re-sync, or tip sync). labels Aug 3, 2026
@mattleibow

Copy link
Copy Markdown
Collaborator Author

Superseded by a fresh target-152 validation run from the updated workflow branch. This validation PR was not merged.

@mattleibow mattleibow closed this Aug 3, 2026
@mattleibow
mattleibow deleted the skia-sync/m152-mattleibow-dev-vulkan-sync-validation branch August 3, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

partner/agentic-workflows Issues and PRs created by SkiaSharp agentic workflows. type/milestone-bump Merges upstream Skia to a new Chrome/Skia milestone (SK_MILESTONE bump). type/milestone-sync Any upstream Skia sync PR (milestone bump, same-milestone bug-fix re-sync, or tip sync).

Projects

None yet

Development

Successfully merging this pull request may close these issues.