You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I build against this exact pattern (the moss Kuru adapter quotes by eth_call-ing the swap path), so two things from running it on mainnet:
The spec gives a venue no way to say "I can't fill right now" as distinct from "the quote failed." Every failure of getAmountOut is a revert, so a router cannot tell a paused or empty venue from a broken quote or an out-of-gas frame. That matters for any router that compares venues exhaustively. On mainnet, one Kuru MON/USDC market reverted every quote with MarketStateError() for two weeks, and a strict comparison refused the whole pair even though three other markets filled. Could the MRC standardize the signal? For example, a venue that cannot fill MUST return amountOut = 0 rather than revert, or a standard PropAMMUnavailable() error, so that a revert unambiguously means failure.
Quote expiry isn't exposed. Execution is guaranteed "before its expiry", but the expiry only lives inside opaque swapData, so a router can't tell when to requote. Would an explicit validUntil return, or a standard error for stale swapData, fit here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New MRC, draft.
This MRC defines a standard routing interface for propAMMs.
Forum post: https://forum.monad.xyz/t/mrc-17-propamm-routing-interface/