realArray: fix arrayCount tracking and assignment size safety#3
Open
spokening125 wants to merge 1 commit into
Open
realArray: fix arrayCount tracking and assignment size safety#3spokening125 wants to merge 1 commit into
spokening125 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves ModuleBase::realArray safety and lifecycle tracking by ensuring the global arrayCount is decremented when memory is released and by preventing size-mismatched copy assignment writes (in debug builds).
Changes:
- Decrement
realArray::arrayCountinsiderealArray::freemem()(triggered by the destructor). - Add an
assert(size == right.size)guard torealArray::operator=(const realArray&)to prevent unsafe copies when sizes differ.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves safety and lifecycle tracking for
realArray.Changes
arrayCountwhen releasing memory.assert(size == right.size)in copy assignment to prevent unsafe size-mismatched writes.Impact
arrayCountaccurate across object destruction.operator=safer in debug builds.