[MOOSE-407]: Block animation classes accumulate in "Additional CSS Class(es)" field#369
Open
spadilha wants to merge 3 commits into
Open
[MOOSE-407]: Block animation classes accumulate in "Additional CSS Class(es)" field#369spadilha wants to merge 3 commits into
spadilha wants to merge 3 commits into
Conversation
GeoffDusome
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do/fix?
Fix animation classes accumulating in "Additional CSS Class(es)" field
When a block had animation settings configured, the
animationControlsHOC was appending animation classes toattributes.classNameand passing them back toBlockEdit. WordPress displaysattributes.classNamein the "Additional CSS Class(es)" field, so any edit to that field would save the animation classes back into the attribute. On the next render, the HOC would append them again on top of what was already there, causing the classes to multiply on every keystroke.The fix removes the
classNameoverride fromblockPropsentirely. Animation classes for the saved output are already handled by theapplyAnimationPropsfilter (blocks.getSaveContent.extraProps), so the HOC never needed to write them back intoattributes.classNamein the first place. The HOC now only overridesstyle(for animation CSS custom properties) and leavesattributes.classNameuntouched.File changed:
wp-content/themes/core/assets/js/editor/block-animations/index.jsQA
Links to relevant issues
Screenshots/video:
Pull request checklist