fix: pass both args when inputSchema omitted in task handler executor#1975
Open
nanookclaw wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: pass both args when inputSchema omitted in task handler executor#1975nanookclaw wants to merge 1 commit intomodelcontextprotocol:mainfrom
nanookclaw wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
When inputSchema is undefined, createToolExecutor now calls
taskHandler.createTask({}, taskCtx) instead of casting to a
single-arg signature. This ensures two-argument handlers receive
correct argument positions: (args, ctx) rather than having
ctx shifted to the first parameter.
Regular tool callbacks remain unchanged — their single-arg
signature matches the TypeScript types.
Fixes modelcontextprotocol#1471
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
registerToolTaskis called withoutinputSchema, two-argument handlers(args, extra)receive incorrect argument positions:argsgets the context object andextraisundefined.This causes a runtime TypeError when the handler tries to access properties like
extra.taskStore:Closes #1471
Root Cause
In
createToolExecutor(packages/server/src/server/mcp.ts), wheninputSchemais undefined, the task handler path castscreateTaskto a single-argument signature and calls it with onlytaskCtx. Any handler written as(args, extra)gets the arguments shifted.Fix
Changed the task handler path to always call
taskHandler.createTask({}, taskCtx)wheninputSchemais undefined, passing an empty object as the first argument so two-argument handlers receive correct positions.Regular tool callbacks are unchanged — their single-arg
(ctx) => Resultsignature matches the TypeScript types and existing behavior.Testing
createTasksignatures consistent with the fix