Skip to content

Add support for post_args on GraphAPI.put_object method (PR #108 update)#344

Closed
ghost wants to merge 2 commits intomasterfrom
unknown repository
Closed

Add support for post_args on GraphAPI.put_object method (PR #108 update)#344
ghost wants to merge 2 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Feb 18, 2017

This should solve merge conflict on #108

Copy link
Copy Markdown
Member

@martey martey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the conflict for #108, but doesn't contain any of the more substantive changes (like updating the documentation or creating a test suite for put_object) that would make this mergeable.

Comment thread facebook/__init__.py

def put_object(self, parent_object, connection_name, **data):
def put_object(
self, parent_object, connection_name,post_args=None, **data):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a PEP8 issue on this line that is causing the linting test to fail.

Comment thread facebook/__init__.py
feed = graph.get_connections("me", "feed")
post = feed["data"][0]
graph.put_object(post["id"], "comments", message="First!")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these lines removed?

@martey
Copy link
Copy Markdown
Member

martey commented Nov 29, 2019

Closing this pull request, since the submitter never responded to my review and has deleted their Github account.

@martey martey closed this Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant