ci: run the test suite on every supported Python version - #253
Open
karpovantonme wants to merge 1 commit into
Open
ci: run the test suite on every supported Python version#253karpovantonme wants to merge 1 commit into
karpovantonme wants to merge 1 commit into
Conversation
The classifiers and requires-python promise 3.10 through 3.14, and the test workflow pinned 3.13, so four of the five promised versions were never exercised. Ran the suite locally on all five first: 188 passed, 5 skipped on each of 3.10, 3.11, 3.12 and 3.14, same as on 3.13. Nothing is broken, the support is real, it just was not guarded. fail-fast is off so one failing version does not hide the others.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
pyproject.tomlpromises five Python versions, in the classifiers and inrequires-python = ">=3.10,<4":pytest.yamlpinspython-version: '3.13', and there is no tox or nox picking up the rest. So four of the five promised versions are never exercised, and a 3.10-only break would ship unnoticed.This adds a matrix over exactly the versions the classifiers list, with
fail-fast: falseso one red version does not hide the state of the others.I ran the suite on all five before proposing this, so this is not a guess about whether they still work:
The support is real. It just was not guarded, which is the part this fixes.
On CI minutes: this turns one job into five, and the suite takes well under a minute, so it should be cheap. If that is still too much on every PR, the other shape is a full matrix on push to
mainand a single version on pull requests. Either works for me, your call.No issue opened for this, since it is a one file change. Can open one if you track things that way.
Checklist:
make test. — run on all five versions, table abovemake pre-commit. — not run, this touches only a workflow filemain).