Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BenchmarksNo baseline from
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React.Children.mapandmapWithIndexreturned mapped children without keys. A React 19.1 development client therefore reportedEach child in a list should have a unique "key" propfor a mappedReact.listorReact.array, where React keys the same children silently. Split out of #399, which adds the Flight validation states this fix is visible through.Lower_case_element,Client_component,Suspense) gets the key React'smapChildrenassigns:.<index in base 36>for an unkeyed member,.$<key>for a keyed member with=and:escaped as=0and=2, and a<mapped key>/prefix when the callback returns an element with a different key.React.Children.toArrayis unchanged.The rules are copied from
mapIntoArray,getElementKey,escape, andescapeUserProvidedKeyinreact@19.1.0.Evidence at
01360e0:dune build @packages/react/runtestruns the newChildren.map keyscase, which checks index keys, base 36 at the eleventh member, keyed and escaped input, callback-key prefixing, slash doubling, text pass-through,mapWithIndex, and the single-element path.Risk: two-way door. A revert restores unkeyed mapped children and the false missing-key warning. Mapped children that already had a key keep it under the
.$prefix, as in React; nothing else reads these keys.