iOS: setup checklist on What this bot does - #957
Conversation
The desktop Overview's "Finish setting up" list, read from the new `setup` field of the overview payload (optional, so older desktops still decode). Steps are informational on the phone; "Set up with the bot" sends /setup to the chat. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Twin of the iOS change: the overview's optional `setup` list rendered as a ticked checklist with "Set up with the bot" sending /setup. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
|
Review against current main: this is still stacked on feat/bot-tools-composer, although #956 was squash-merged and its setup behavior has since changed. Merging main into the current stack produces conflicts across old server/UI setup changes, so the two phone commits should be lifted cleanly onto main rather than restoring that old setup implementation. Please also align the heading/footer/fixture with the current optional customization flow (no mandatory first-message step): chat works before setup and /setup is opt-in. Both phone buttons currently report Sent without checking acceptance, and iOS allows repeat taps while awaiting send; please cover failed/offline sends and prevent double submission. Holding this version rather than reviving the setup regression. |
In plain language
The phone half of #956's setup checklist. "What this bot does" (bot profile → Identity) now opens with Finish setting up · n of m done: name and job, standing instructions, working folder, connected apps, a schedule or trigger, a first message. Done steps are ticked and struck through.
The steps point at desktop settings sections a phone cannot open, so they read as a list here. The one thing the phone can do is Set up with the bot, which sends
/setupto the chat so the bot interviews you and fills the rest in itself.Per-bot MCP servers, roles, paste-import and the composer tray from #956 are not ported, on purpose: a paired phone may not change a bot's execution policy (
companion/src/routes.ts).What changed
ios/Sources/CompanionCore/Models.swift:BotOverviewSetupStep;BotOverview.setup(optional, so older desktops still decode) andremainingSetup.ios/App/BotOverviewView.swift: the checklist section and the/setupbutton.bot-overview.jsonrecaptured from a disposable harness (--overview-only); Android's suite reads the same file.Test plan
swift test: 338 passing, including decoding the checklist and an overview without onexcodegen generate+ simulator compile gate: BUILD SUCCEEDEDStacked on #956 (base
feat/bot-tools-composer).Platforms
GET /api/bots/:id/overview; the/setupmessage goes through the existing send route🤖 Generated with Claude Code