Conversation
|
@casquijo is attempting to deploy a commit to the SupaMaus Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Triage update: #1135 is now merged, so the room spend-cap guard, room ledger entries, blocked-goal outcome, and live budget fields already exist on main. This PR is not wholly redundant: capturing the initiating user on each operation/queued item still matters. Current main reads turnTriggers at settlement, which a later queued sender can overwrite. Please rebase this as the narrower immutable-attribution follow-up, preserving the queued-user, calendar-owner, and routine-goal regressions, without adding a second spend/ledger path. Holding the current overlapping version rather than closing it as a duplicate. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Direct turns were accounted for and capped, but provider-backed room and calendar turns could proceed without equivalent ledger entries or dispatch-time enforcement.
This ensures settled room usage is visible before the next member dispatch and that all affected paths observe the same monthly cap.
How it was verified
pnpm typecheckpnpm lintpnpm testScreenshots (UI changes)
Not applicable — no UI changes.
Checklist
pnpm typecheckandpnpm testpass locallydist-server/edits