Add registry delete_value and delete_tree helpers#638
Draft
benhillis wants to merge 1 commit into
Draft
Conversation
Surface public delete APIs for the wil::reg namespace, mirroring the existing throwing/nothrow pattern used by the rest of the registry helpers: - delete_value[_nothrow](key, value_name) -> RegDeleteValueW - delete_value[_nothrow](key, subKey, value_name) -> RegDeleteKeyValueW - delete_tree[_nothrow](key, subKey) -> RegDeleteTreeW (recursive, succeeds when the subkey is already absent) The reg_view_t backing methods for RegDeleteValueW/RegDeleteTreeW already existed; this adds the RegDeleteKeyValueW overload and the public wrappers, plus coverage in RegistryTests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
wil::reg::delete_value[_nothrow](RegDeleteValueW + RegDeleteKeyValueW subkey overloads) anddelete_tree[_nothrow](RegDeleteTreeW, swallowing not-found). Includes Catch2[registry]tests passing in normal & noexcept configs. Part of enabling WSL to drop its in-house registry helper in favor of wil::reg.