Skip to content

sessions: disable chat tips in agents window#308395

Merged
osortega merged 1 commit intomainfrom
copilot/bumpy-mink
Apr 7, 2026
Merged

sessions: disable chat tips in agents window#308395
osortega merged 1 commit intomainfrom
copilot/bumpy-mink

Conversation

@osortega
Copy link
Copy Markdown
Contributor

@osortega osortega commented Apr 7, 2026

Summary

Registers a NullChatTipService in the sessions layer to suppress getting-started tips in the agents window.

Problem

When switching between sessions in the agents window, the "Tip: Try the Plan agent..." message briefly flashes above the chat input. This happens because the chat widget temporarily has zero items while session messages are loading, and updateChatViewVisibility() treats that as an empty/new session — rendering the tip. Once messages arrive, the tip disappears.

Solution

Follow the existing pattern used by NullInlineChatSessionService — register a no-op IChatTipService implementation in the sessions layer (src/vs/sessions/) that always returns undefined from getWelcomeTip(). This completely suppresses tips in the agents window without modifying any core workbench code.

Changes

  • New: src/vs/sessions/contrib/chat/browser/nullChatTipService.ts — null implementation of IChatTipService
  • Modified: src/vs/sessions/contrib/chat/browser/chat.contribution.ts — import the null service registration

Register a NullChatTipService in the sessions layer to suppress the
getting-started tips that flash briefly when switching between sessions.
The empty-state tip was showing during session loading because the chat
widget temporarily has zero items before messages arrive.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 7, 2026 23:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables “getting-started” chat tips in the Agents (sessions) window by overriding the workbench IChatTipService with a sessions-layer no-op implementation, preventing the tip UI from flashing during session switching while messages load.

Changes:

  • Add a sessions-layer NullChatTipService that always returns undefined from getWelcomeTip() and no-ops all other IChatTipService methods.
  • Register the null tip service via a side-effect import in the sessions chat contribution module.
Show a summary per file
File Description
src/vs/sessions/contrib/chat/browser/nullChatTipService.ts Introduces a no-op IChatTipService singleton for the sessions window to suppress welcome tips.
src/vs/sessions/contrib/chat/browser/chat.contribution.ts Ensures the null tip service is registered in the sessions layer by importing it alongside other sessions-only chat overrides.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@osortega osortega merged commit 884e76f into main Apr 7, 2026
27 checks passed
@osortega osortega deleted the copilot/bumpy-mink branch April 7, 2026 23:49
@vs-code-engineering vs-code-engineering bot added this to the 1.116.0 milestone Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants