feat: restore windows to their original macOS Spaces on restart#308301
Open
tnayuki wants to merge 2 commits intomicrosoft:mainfrom
Open
feat: restore windows to their original macOS Spaces on restart#308301tnayuki wants to merge 2 commits intomicrosoft:mainfrom
tnayuki wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Add electron-osx-spaces dependency to save and restore the Space (virtual desktop) each window belongs to. This uses AppKit's native NSWindow state restoration APIs via the electron-osx-spaces package. Fixes microsoft#123517
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #123517
Summary
electron-osx-spacesas a dependency to save and restore the macOS Space (virtual desktop) each window belongs toNSWindowstate restoration APIs (encodeRestorableStateWithCoder:/restoreStateWithCoder:) via theelectron-osx-spacespackageIWindowState.macOSRestorableStateChanges
package.jsonelectron-osx-spacesto dependencieswindow.tsmacOSRestorableStatefield toIWindowStatewindowImpl.tsHow to test
Cmd+Shift+N)Cmd+Q)Compatibility
macOSRestorableStateis optional; old state data works without itelectron-osx-spacesreturns no-op on non-macOS platformsNSWindowRestoresWorkspaceAtLaunchbeing broken (FB15644170)