fix: add keybinding expression for hiding inline suggestions#308187
Merged
fix: add keybinding expression for hiding inline suggestions#308187
Conversation
Contributor
Screenshot ChangesBase: Changed (2)
|
| Before | After |
|---|---|
 |
 |
editor/suggestWidget/MethodCompletions/Light
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an Escape keybinding conflict where editor.action.inlineSuggest.hide was being invoked while inline chat was open, preventing Escape from closing inline chat when ghost text is visible.
Changes:
- Restricts the default Escape keybinding for “Hide Inline Suggestion” to only apply when the editor text has focus (
EditorContextKeys.editorTextFocus).
Show a summary per file
| File | Description |
|---|---|
| src/vs/editor/contrib/inlineCompletions/browser/controller/commands.ts | Narrows the Escape keybinding context for hiding inline suggestions so it doesn’t steal Escape outside the editor text focus (e.g. inline chat UI). |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
alexdima
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #306706