fix: respect chat.promptFilesLocations ordering for file discovery#308171
Open
maruthang wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: respect chat.promptFilesLocations ordering for file discovery#308171maruthang wants to merge 1 commit intomicrosoft:mainfrom
maruthang wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The getSourceFoldersInDiscoveryOrder method now preserves the configuration order instead of hardcoding user-before-local. Added listAllFilesInOrder to return files with storage metadata in their configured order, and updated computeListPromptFiles to use it instead of separate user/local calls. Fixes microsoft#305876
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getSourceFoldersInDiscoveryOrder()to preserve the user's configured ordering inchat.promptFilesLocationsinstead of hardcoding user-before-locallistAllFilesInOrder()method toPromptFilesLocatorthat returns files with storage metadata in their configured ordercomputeListPromptFiles()inpromptsServiceImpl.tsto use the new ordered listing instead of making separate user/local calls that always put user firstTest plan
chat.promptFilesLocationswith local paths before user paths (e.g.,{ ".prompts": true, "~/prompts": true }).promptsappear before those from~/promptsin the prompt file pickerFixes #305876